✨ Update SIP-366 #1938
Merged
✨ Update SIP-366 #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kaleb-keny
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Hi @JaredBorders thanks for writing this up with all the details, really allows me to provide a worthy review 🤝
content/sips/sip-366.md
Outdated
| 3. Ensure the intent's submission timestamp is greater than the current timestamp plus the applicable delay. | ||
| 4. Ensure the intent's submission timestamp does not surpass the current timestamp plus both the delay and window period. | ||
| 5. Check that processing the intent won't cause the collateralization ratio to fall below the required issuance ratio. | ||
| 6. Update the `escrowedCollateralByAccount` to mirror the amount of collateral in process for the designated account and pool. |
There was a problem hiding this comment.
Goes without saying, that if a user pushed an intent to delegate, then he should be blocked from withdrawing that delegated collateral. As if the collateral had been delegated. Does this make sense? And should we add this to the workflow, as it might need to alter core?
kaleb-keny
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new SIP, please use the suggested template: https://github.com/Synthetixio/SIPs/blob/master/sip-X.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: