Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sccp-2138.md to Implemented #2119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cavalier-eth
Copy link
Contributor

When opening a pull request to submit a new SIP, please use the suggested template: https://github.com/Synthetixio/SIPs/blob/master/sip-X.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing Draft PRs.
  • The build passes.
  • Your Github username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sips ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:17am

Copy link
Member

@kaleb-keny kaleb-keny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh hold on, these need a vote link, didn't forget this time 😅

@cavalier-eth
Copy link
Contributor Author

cavalier-eth commented Oct 17, 2024

ohh hold on, these need a vote link, didn't forget this time 😅

all added but some tests still seem to be failing and it doesn't seem to be consistent

@kaleb-keny
Copy link
Member

ohh hold on, these need a vote link, didn't forget this time 😅

all added but some tests still seem to be failing and it doesn't seem to be consistent

instead of

proposal: >-
  https://gov.synthetix.io/#/proposal/0xc14f719687bfee53b436957bda6d631bc3f1847ce11e3f76945d49d36d46adbd

please use

proposal: >-
  https://snapshot.org/#/snxgov.eth/proposal/0xc14f719687bfee53b436957bda6d631bc3f1847ce11e3f76945d49d36d46adbd

snapshot works gov.synthetix doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants