This repository has been archived by the owner on May 17, 2021. It is now read-only.
Remove eth when calculating sUSD #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah you're right, I can take care of it. |
|
@bachstatter ETH in the table represents your ETH balance. Real ETH, not sETH. |
0xclem
approved these changes
Nov 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed ETH from the sUSD conversion.
Eth is used in a lot of places, like when we calculate gas price etc.
I could try and refactor that, but it might be quicker for you @clementbalestrat since you wrote the code?
Just let me know if you think it's worth me spending time on that.
I also has some questions regarding the UI that says it displaying ETH and not sETH. (#107 )