Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Duplicate Lipoic Acid Biosynthesis Pathways #707

Merged
merged 10 commits into from
Oct 17, 2023
Merged

Merge Duplicate Lipoic Acid Biosynthesis Pathways #707

merged 10 commits into from
Oct 17, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #682:

  • Merges annotations for MAR06400 in reactions.tsv into those for MAR06403
  • Removes MAR06400 for being a less accurate version of MAR06403
  • Merges annotations for MAR06401 in reactions.tsv into those for MAR06402
  • Removes MAR06401 for being a less accurate version of MAR06402
  • Removes now-isolated MAM02397c (lipoyl-[ACP])

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

feiranl
feiranl approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo mentioned this pull request Oct 16, 2023
Merged
3 tasks
@haowang-bioinfo haowang-bioinfo merged commit 1138c5c into develop Oct 17, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/dupe_lipoate_biosynth branch October 17, 2023 19:48
@haowang-bioinfo haowang-bioinfo mentioned this pull request Oct 17, 2023
Closed
5 tasks
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

@haowang-bioinfo haowang-bioinfo haowang-bioinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devlin-Moyer @haowang-bioinfo @feiranl