automatically convert local file paths to file url #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klieber
force-pushed
the
feature/generate-local-file-urls
branch
from
e569644 to
818198a
Compare
Szpadel
requested changes
Nov 4, 2020
In the current version of the script you must use the syntax `file:///path/to/file` when referencing a local file. This works but can be difficult to work with when you simply want to build a pdf for a file in the current directory. You can do something like `file://$(realpath index.html)` but that is not cross platform and doesn't work in environments like Git Bash for Windows. This change utilizes the [file-url](https://www.npmjs.com/package/file-url) package to automatically convert local file paths to a file url. It will only do so when the provided url does not start with `http`, `https`, or `file`.
klieber
force-pushed
the
feature/generate-local-file-urls
branch
from
818198a to
7895235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the script you must use the syntax
file:///path/to/filewhen referencing a local file. This works but can be difficult to work with when you simply want to build a pdf for a file in the current directory. You can do something likefile://$(realpath index.html)but that is not cross platform and doesn't work in environments like Git Bash for Windows.This change utilizes the file-url package to automatically convert local file paths to a file url. It will only do so when the provided url does not start with
http,https, orfile.