-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/WP-798: Setup Defaults for Query Client #395
Open
jalowe13
wants to merge
107
commits into
main
Choose a base branch
from
Bug/WP-798--Setup-defaults-for-query-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…276) * Initial commit - using react with APCD page * remove visualizer * Remove print statements * Renamed shared-components to core-components
…276) * Initial commit - using react with APCD page * remove visualizer * Remove print statements * Renamed shared-components to core-components
…276) * Initial commit - using react with APCD page * remove visualizer * Remove print statements * Renamed shared-components to core-components
…-Custom into feat/apcd-react-conversion
…-Custom into feat/apcd-react-conversion
* apcd admin submissions react page version 1 * moved filter and sort functionality to react * Added View logs modal using reactstrap modal --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
* feat: Add ViewUsers component * chore: Update Docker Compose dev configuration for React * refactor: Update ViewUsers component and related files * refactor: Update ViewUsers component and related files * feat: Add user action dropdown in ViewUsers component * Filter by Status and Org now work * URL updated w/ status and org * URL updates to show status and/or organization --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
…react (#294) * Setup vite local and template with react content * Update Makefile
Modal windows not included
* first run at the react conversion * Update list_admin_extension.html from merge feat branch * Updated incorrect import --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
* feat: Add user action dropdown in ViewUsers component * Add ViewRecordModal component and styles for user details modal * Update ViewRecordModal component and styles for user details modal * Update ViewRecordModal component and styles for user details modal * Create Edit Record modal * Add Success and Error modals * Update EditRecordModal component and fix error handling * Add support for fetchUtil request method and use it in EditRecordModal * Add update user method * Add pagination to ViewUsersTable component * Update ViewUsersTable component with duplicate path in urls.py * Update EditRecordModal component and fix error handling * Remove link --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
…Core-CMS-Custom into feat/apcd-react-conversion
* Update RegistrationList and ViewRegistrationModal to display 'None' when year, reg_status, fein, license, or naic is undefined or null --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
…Core-CMS-Custom into feat/apcd-react-conversion
…Core-CMS-Custom into feat/apcd-react-conversion
Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
* WP-795: clear options button similarity across all pages * set styles
* Default filter admin submissions listing to 'status=In Process' * Default filter admin users listing to 'status=Active'
* Merge features from main to apcd feature branch * Fix id field --------- Co-authored-by: Garrett Edmonds <43251554+edmondsgarrett@users.noreply.github.com>
…ults-for-query-client
- Removes toggle from success and error message to mimic behavior in other edit modals - Will revisit handling of success messages after React initial release
* react-strap buttons * submit attribute for formik * edit record modal submit attribute --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
* initial commit * Validation Users Edit Record Modal * Exception Modal * ExtensionModal * error above, succsess inline * EditRecord QueryWrapper * QueryWrapper ExceptionModal * pill inline fix * removed non required pills --------- Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
* Fix syntax error in sql * move left join before where
* Created new blank page at URL administration/view-submitter-users * Began building of Submitter Users Page * All Users shown on table; working on filtering by Submitter-User role * Established SQL query to get submitter users; set up views.py * Still working on getting the site to load the data * Got table of submitter users to appear * View modal opens and closes * Edit Modal opens and closes; can't edit records yet * Edit modal updates user names and emails correctly * Added View Submitter Users site to navbar * Linted client code * Removed changes to apcd_cms/src/client/main.tsx * Removed extraneous HTML files and commented-out portions * Update apcd_cms/src/apps/utils/apcd_database.py Simplify the database connection Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu> * Update apcd_cms/src/apps/utils/apcd_database.py Sort users by user ID Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu> * Update apcd_cms/src/apps/utils/apcd_database.py Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu> --------- Co-authored-by: Jeff McMillen <jm63959@TACCs-MacBook-Pro.local> Co-authored-by: Chandra Y <cyemparala@tacc.utexas.edu>
…ults-for-query-client
chandra-tacc
previously requested changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove existing usages of staleTime in
useUserFilters and useSubmissionFilters (and in anyother place in the code).
These defaults should help instead of values at each hook
chandra-tacc
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Setup defaults for query client
…
Related
Changes
Testing
{staleTime: 300000, cacheTime: 600000, refetchOnWindowFocus: false, queryKey: Array(1), queryFn: ƒ, ...}
UI
…