Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Duplicate applicable data periods in extensions form #406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edmondsgarrett
Copy link
Contributor

@edmondsgarrett edmondsgarrett commented Jan 9, 2025

Overview

Addresses bug where a user with multiple submitters will see duplicate applicable data period options on the extensions form

Related

Changes

  • Factors out the applicable data periods db query from collating the list of user's submitters, now keeps this list of data periods separate for each submitter
  • Adds listener to business name dropdown to update list of applicable period options when business name (read: submitter) is changed

Testing

  1. Go to http://localhost:8000/submissions/extension-request/
  • If you only have one submitter available in the dropdown, Carrie can help add other submitters for you in our dev db
  1. Check the 'Applicable Data Period' dropdown and confirm a sorted list of year-month entries are there, then select one and confirm the 'Current Expected Date' box populates with a date
  2. Choose a different option under 'Business Name' and confirm that the above options change + the 'Current Expected Date' box updates with the default mm/dd/yyyy
  3. Test with additional extensions entries and confirm they work the same + do not conflict with each other

UI

Copy link
Member

@happycodemonkey happycodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants