Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-639 move c-button font-weight bold to cms #740

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 2, 2023

Overview

All c-button font-weight bold to CMS.

Related

Changes

  • changed c-button font-weight to always be bold
  • changed c-button styles to use custom selector

Testing & UI

See TACC/tup-ui#364.

@wesleyboar wesleyboar changed the title Fix/tup 617 c button font weight fix: tup-617 move c-button font-weight bold to cms Nov 2, 2023
@wesleyboar wesleyboar changed the title fix: tup-617 move c-button font-weight bold to cms fix: tup-639 move c-button font-weight bold to cms Nov 2, 2023
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

• Tested on Core-CMS and TUP-UI, no side effects
• Looks like a simple change, migrated from tup-ui -> core-styles (then deleted) -> to core-cms

@wesleyboar
Copy link
Member Author

wesleyboar commented Nov 3, 2023

Ideally, this PR also loads a new version of Core-Styles that includes TACC/Core-Styles#253. But, I don't wanna update Core-Styles version from 2.11 to 2.19 not fully tested for all those changes just to avoid (a) some extra CSS and (b) not-yet-bold text. I'll update Core-CMS's version of Core-Styles in isolation just after merging this.

@wesleyboar wesleyboar merged commit 1626fac into main Nov 3, 2023
@wesleyboar wesleyboar deleted the fix/tup-617-c-button-font-weight branch November 3, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants