fix: c-card--frontera variant misc bugs (#252)

* fix: top of c-card--frontera link outlines hidden Wrap c-card--frontera in section to add space for seeing link outlines. * chore: do not double-load c-card--frontera styles * fix: c-card--frontera wrongly has c-card padding * chore: remove excess code and comment
TACC · Nov 2, 2023 · d8630b6 · d8630b6
1 parent b20884a
commit d8630b6
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/dist/components/c-card--frontera-about-page.css b/dist/components/c-card--frontera-about-page.css
diff --git a/dist/core-styles.cms.css b/dist/core-styles.cms.css
diff --git a/src/lib/_imports/components/c-card--frontera-about-page.css b/src/lib/_imports/components/c-card--frontera-about-page.css
@@ -5,6 +5,8 @@
 
   border-bottom: var(--global-border-width--normal) solid var(--global-color-primary--dark);
   margin-bottom: 4.6rem;
+
+  padding: unset; /* overwrite .c-card */
 }
 
 

diff --git a/src/lib/_imports/components/c-card/c-card--frontera.hbs b/src/lib/_imports/components/c-card/c-card--frontera.hbs
@@ -1,3 +1,5 @@
+<section class="o-section">
+
 <!-- FAQ: Not using {{this._self.name}} because class is frontera-about-page -->
 <div class="o-grid o-grid--col-min-width">
   <a href="#" class="c-card c-card--frontera-about-page">
@@ -46,3 +48,5 @@
     <h3>Style ▸ Image + Text</h3>
   </div>
 </div>
+
+</section>
diff --git a/src/lib/_imports/components/c-card/config.yml b/src/lib/_imports/components/c-card/config.yml
@@ -24,6 +24,3 @@ variants:
     status: deprecated
     📝 name: using "frontera-about-page" breaks the demo
     label: Frontera About Page
-    context:
-      supportStyles:
-        - ../../assets/components/c-card--frontera-about-page.css
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,6 +5,8 @@ @@
       border-bottom: var(--global-border-width--normal) solid var(--global-color-primary--dark);
       margin-bottom: 4.6rem;
+      padding: unset; /* overwrite .c-card */
     }
@@ Expand Down @@