Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tup-624: added generics/attributes to demo #244

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez commented Oct 12, 2023

Overview

Add in the data-prefix css for generics/attributes

Related

Changes

added attributes styles
added attributes demo

  • Remove from c-button in Core-Styles

Testing

Open and Review:
http://localhost:3000/components/detail/attributes
http://localhost:3000/components/detail/c-button--primary

UI

Screenshot 2023-10-12 at 12 45 28 PM Screenshot 2023-10-12 at 5 25 21 PM

@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Oct 12, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez added the minor A feature in backward-compatible manner label Oct 12, 2023
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did this together, so I saw it working. And it's good. But please fix the diff, so I can verify what has changed.

@wesleyboar wesleyboar changed the base branch from main to feat/tup-463 October 13, 2023 16:18
@wesleyboar wesleyboar merged commit 8ac827d into feat/tup-463 Oct 13, 2023
@wesleyboar wesleyboar deleted the feat/tup-624-generics-attribute branch October 13, 2023 18:59
wesleyboar added a commit that referenced this pull request Oct 13, 2023
* style: fix a quote mistake

* feat: tup-624: added generics/attributes to demo (#244)

* added generics/attributes to demo

* added disabled attr pointer-events to generics/attributes

---------

Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>

* feat: tup-619 c-content-block migration (#245)

* feat: tup-610 content-block migration

* quick fix, moved import from base to cms

* moved import from base to cms

* delete dist file for content-block

---------

Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>

---------

Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants