Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup 637: Migrate c-card support list to core-styles #250

Merged
merged 15 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/components/c-card-list.css
wesleyboar marked this conversation as resolved.
Show resolved Hide resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/core-styles.cms.css

Large diffs are not rendered by default.

21 changes: 21 additions & 0 deletions src/lib/_imports/components/c-card-list.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
@import url("./c-card.selectors.css");

/* SUPPORT LIST IN CARD */

/* FAQ: The Portal uses Bootstrap ".card" for ticket modal */
:is(.card, :--c-card, [class*="card--"]) ul {
/* list-style: none; *//* H.P. restored bullets, M.S. does not know */
padding-left: 1em; /* overwrite core-styles.cms */
}
/* To add space between line items */
/* FAQ: Using margin and li:not(:first-of-type) because of multi-line items */
:is(.card, :--c-card, [class*="card--"]) li:not(:first-of-type) {
margin-top: 0.5em;
}
/* TODO: Consider changing this site wide; SEE:
:where([role=main],main) li:not(td li) { line-height: 1.6; } */
/* Tomas removes `:where(:not(…` (e.g. "not in portal"). He saw it needed to be
removed elsewhere. */
:is(.card, :--c-card, [class*="card--"]) ul:last-child {
margin-bottom: 2rem;
}
7 changes: 7 additions & 0 deletions src/lib/_imports/components/c-card/_c-card--list.hbs
R-Tomas-Gonzalez marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<article class="c-card c-card--plain">
<h3>Card - List</h3>
<ul>
<li><a href="#">Required Forms</a></li>
<li><a href="#">Camp Program</a></li>
</ul>
</article>
7 changes: 7 additions & 0 deletions src/lib/_imports/components/c-card/_c-card--many-variable.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,12 @@
</p>
<a href="#"><i class="icon icon-push-right">&gt;</i> Learn more</a>
</article>
<article class="c-card c-card--{{this._self.name}}">
<h3>Card - List</h3>
<ul>
<li><a href="#">Required Forms</a></li>
<li><a href="#">Camp Program</a></li>
</ul>
</article>

<p style="grid-column: 1/-1;">* Wrapping in a <kbd>&lt;p&gt;</kbd> tag was a fix in early 2023-01, but is now non-standard.</p>
1 change: 1 addition & 0 deletions src/lib/_imports/core-styles.cms.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
@import url("./components/c-content-block.css");
@import url("./components/cortal.icon.css");
@import url("./components/c-card.css");
@import url("./components/c-card-list.css");
@import url("./components/c-form--cms.css");
@import url("./components/c-message.css");
@import url("./components/c-message--expanded.css");
Expand Down