Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup 617: Migrate c-card fixes to core-styles #251

Merged
merged 9 commits into from
Nov 2, 2023
Merged

feat/tup 617: Migrate c-card fixes to core-styles #251

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be9faec
Added in card style fixes
R-Tomas-Gonzalez Oct 26, 2023
949cc7a
Added in card style fixes. Made adjustments to variables and syntax
R-Tomas-Gonzalez Oct 26, 2023
d00b2e4
removes unnecessary style because it already exists
R-Tomas-Gonzalez Oct 26, 2023
0cf152c
Adds back in style. It allows for more specificity.
R-Tomas-Gonzalez Oct 26, 2023
29f413d
clean up comment
R-Tomas-Gonzalez Oct 26, 2023
63cdd37
Update src/lib/_imports/components/c-card.css
R-Tomas-Gonzalez Nov 2, 2023
6f99d0d
Update src/lib/_imports/components/c-card.css
R-Tomas-Gonzalez Nov 2, 2023
b12a1c3
Update src/lib/_imports/components/c-card.css
R-Tomas-Gonzalez Nov 2, 2023
3d8ee2e
Resolved conflicts
R-Tomas-Gonzalez Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/components/c-card.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/core-styles.cms.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-styles.docs.css
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 14 additions & 0 deletions src/lib/_imports/components/c-card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,3 +186,17 @@
line-height: 1.7;
margin-bottom: 2rem; /* to mimic <p> */
}

:is(.card, :--c-card) p:last-child {
margin-bottom: 2rem; /* restore <p> `margin-bottom `*/
}
R-Tomas-Gonzalez marked this conversation as resolved.
Show resolved Hide resolved

/* To allow more specifically control c-card link font weight */
:is(.card, :--c-card) a:--c-button {
font-weight: var(--bold);
}
R-Tomas-Gonzalez marked this conversation as resolved.
Show resolved Hide resolved

/* FAQ: Used on image cards for staff like on /education/k-12-students/ */
:is(.card, :--c-card) h4 {
R-Tomas-Gonzalez marked this conversation as resolved.
Show resolved Hide resolved
margin-bottom: 0.375em;
}
Loading