Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: c-card--frontera variant misc bugs #252

Merged
merged 4 commits into from
Nov 2, 2023
Merged

fix: c-card--frontera variant misc bugs #252

merged 4 commits into from
Nov 2, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 2, 2023 •
edited
Loading

Overview

Fix various bugs with c-card--frontera pattern and demo.

Related

Changes

  • added style to undo base card padding
  • added .o-section wrapper around demo markup
  • removed load of redundant supportStyles

Testing

  1. Open http://localhost:3000/components/detail/c-card--frontera.
  2. Hover over a card that is a link.
  3. Verify outline on hover is fully visible.
  4. Verify card has no excess padding e.g. outline is consistently offset around card content.
  5. Verify c-card--frontera styles are not applied twice.
  6. Verify pattern in demo looks like pattern on https://dev.fronteraweb.tacc.utexas.edu/2022/about/.\
    Exceptions:
    • outline color (because it is a dynamic accent color)
    • link text-decoration on normal and hover (because both overwrites are necessary)

UI

new old
new old

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Nov 2, 2023
@wesleyboar wesleyboar changed the title Fix/c card frontera variant misc bugs fix: c-card--frontera variant misc bugs Nov 2, 2023
@wesleyboar wesleyboar added the patch A backward-compatible fix label Nov 2, 2023
@wesleyboar wesleyboar mentioned this pull request Nov 2, 2023
Merged
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-requested a review November 2, 2023 17:36
@wesleyboar wesleyboar merged commit d8630b6 into main Nov 2, 2023
@wesleyboar wesleyboar deleted the fix/c-card-frontera-variant-misc-bugs branch November 2, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees

@wesleyboar wesleyboar

Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez