Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: tup 644 footer not sticky during edge case #256

Merged
merged 4 commits into from
Nov 14, 2023
Merged

hotfix: tup 644 footer not sticky during edge case #256

merged 4 commits into from
Nov 14, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 7, 2023 •
edited
Loading

Overview

Sticky footer even if content is in between main and footer.

Related

Changes

  • added content to reveal edge case
  • changed selector to cover edge case

Testing

  1. Open http://localhost:3000/components/detail/sticky-footer.
  2. Verify even with unexpected content, footer still sticks to bottom of page.

UI

Before, no Edge Case Before, w/ Edge Case After, w/ Edge Case Mimic Fix on TUP
BEFORE no edge case for bug DURING show edge case for bug AFTER fix edge case for bug AFTER mimicking fix on TUP

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Nov 7, 2023
@wesleyboar wesleyboar changed the title Hotfix/tup 644 footer not sticky during edge case hotfix: tup 644 footer not sticky during edge case Nov 7, 2023
@wesleyboar wesleyboar added the patch A backward-compatible fix label Nov 7, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-requested a review November 14, 2023 22:05
R-Tomas-Gonzalez
R-Tomas-Gonzalez approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wesleyboar wesleyboar merged commit 3149826 into main Nov 14, 2023
@wesleyboar wesleyboar deleted the hotfix/tup-644-footer-not-sticky-during-edge-case branch November 14, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees

@wesleyboar wesleyboar

Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez