Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: tup 644 footer not sticky during edge case #256

Merged
merged 4 commits into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/core-styles.cms.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-styles.portal.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/elements/sticky-footer.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/elements/sticky-footer/demo.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/lib/_imports/elements/sticky-footer.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* To make a footer stick to bottom of page */
/* https://css-tricks.com/a-clever-sticky-footer-technique/ */
body > main + footer {
body > main ~ footer {
position: sticky;
top: 100vh;
}
5 changes: 5 additions & 0 deletions src/lib/_imports/elements/sticky-footer/demo.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

/* To style the footer, see trumps/s-footer.css */

aside {
text-align: center;
font-style: italic;
}

footer {
text-align: center;
background-color: var(--global-color-primary--light);
Expand Down
3 changes: 3 additions & 0 deletions src/lib/_imports/elements/sticky-footer/sticky-footer.hbs
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<main>
<p>Sample body content. Footer is at bottom of page.</p>
</main>
<aside>
<p>Unexpected content.</p>
</aside>
<footer class="s-footer s-footer--thin">
<p>
Sample footer content.
Expand Down