feat/tup-486 Create text-wrap for longer links #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature
R-Tomas-Gonzalez
changed the title
wesleyboar
reviewed
Nov 15, 2023
I noticed that top and relative effects other button icons that have middle alignment.
wesleyboar
reviewed
Nov 15, 2023
wesleyboar
approved these changes
Nov 16, 2023
|
I noticed the removal of some changes, because icon alignment differs in certain contexts (b46b218). Reasonable decision. Even before this, the alignment differs; so, "fixing icon alignment" can be a separate task, and this PR can be just "fixing wrapping". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adjust card text wrap and icon placement
Related
Changes
Testing
Note: When testing, localhost:8000 will use the 1.2em attribute. However, TACC production site uses
font-size: 1em/1 cortal.https://www.tacc.utexas.edu/use-tacc/getting-started/
• Protected Data Services card
• STEM Evaluation Services
UI
Notes
Maybe we should delete the font-size or comment it out in core-styles?
*Left it in case this becomes the new norm or this was something that was previously wanted by designers.