Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: django-cms-forms unstyled in demo #268

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

wesleyboar
Copy link
Member

Overview

Load django-cms-forms custom styles in demo.

Related

Changes

  • removed duplicate code
  • added supportStyles so django-cms-forms loads its custom code
  • fixed incomplete comment

Testing

  1. Open http://localhost:3000/components/preview/django-cms-forms.
  2. Press [Toggle Field Errors] button (at bottom of page).
  3. Verify errors appear just above respective help text (not respective above label).

UI

before after
before after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Nov 21, 2023
@wesleyboar wesleyboar added patch A backward-compatible fix fix Fixes user-facing behavior or feature and removed fix Fixes user-facing behavior or feature labels Nov 21, 2023
@wesleyboar wesleyboar merged commit 0ba9a5a into main Nov 21, 2023
8 of 9 checks passed
@wesleyboar wesleyboar deleted the hotfix/django-cms-forms-not-styled branch November 21, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant