-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw verification options #122
Conversation
mtygesen
commented
Dec 5, 2023
- Added ability to write raw verification options to the engines in "Edit Query"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all engines, if you click the checkbox on "Use" please, populate the text field with -x 1 (otherwise the verification fails).
Also, remember the string with verification options also after closing the dialog (so that next time I open it, it shows the same string as previously edited). And remember also that it was selected, so that next time you open it it is selected again.
When used with verifydtapn engine (e.g. in intro-example), disable also the approximation options (and swap the placement of verification options and approximation options).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, enable the help on options to be open and at the same time allow to edit the raw options text field (like it is done in batch processing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All works but if you in the query dialog enter manual query edit and parse it immediately (while having enabled "Use" box), after the parsing the query dialog it shows "Use" still enabled plus some other enabled options that should be grayed out.
… if using raw verification options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small issues: the Verification option dialog should be only enabled for verifypn, verifydtapn and verifytapn engine but not for UPPAAL translations (there are several variants). If you open e.g. alternating bit protocol then in the query, you can select UPPAAL translations and if use click on "Use" and e.g. verification options, you get an error. If UPPAAL translation is selected in the dropdown menu then it should not be possible to tick off the box "Use".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, so we will merge it now.