Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw verification options #122

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Raw verification options #122

merged 11 commits into from
Dec 13, 2023

Conversation

mtygesen
Copy link
Contributor

@mtygesen mtygesen commented Dec 5, 2023

  • Added ability to write raw verification options to the engines in "Edit Query"

@srba srba self-requested a review December 6, 2023 22:09
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all engines, if you click the checkbox on "Use" please, populate the text field with -x 1 (otherwise the verification fails).

Also, remember the string with verification options also after closing the dialog (so that next time I open it, it shows the same string as previously edited). And remember also that it was selected, so that next time you open it it is selected again.

When used with verifydtapn engine (e.g. in intro-example), disable also the approximation options (and swap the placement of verification options and approximation options).

@srba srba self-requested a review December 10, 2023 16:36
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, enable the help on options to be open and at the same time allow to edit the raw options text field (like it is done in batch processing).

@srba srba self-requested a review December 12, 2023 08:47
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works but if you in the query dialog enter manual query edit and parse it immediately (while having enabled "Use" box), after the parsing the query dialog it shows "Use" still enabled plus some other enabled options that should be grayed out.

@srba srba self-requested a review December 12, 2023 20:14
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issues: the Verification option dialog should be only enabled for verifypn, verifydtapn and verifytapn engine but not for UPPAAL translations (there are several variants). If you open e.g. alternating bit protocol then in the query, you can select UPPAAL translations and if use click on "Use" and e.g. verification options, you get an error. If UPPAAL translation is selected in the dropdown menu then it should not be possible to tick off the box "Use".

@srba srba self-requested a review December 13, 2023 09:23
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, so we will merge it now.

@srba srba merged commit 0d63205 into TAPAAL:main Dec 13, 2023
1 check passed
@mtygesen mtygesen deleted the engine-switch-textarea branch December 13, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants