Handle non-circular internal references in serialiseValue

TAServers · Dec 23, 2023 · e18118e · e18118e
1 parent 8dbdc8b
commit e18118e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/lest/src/lua/utils/serialise-value.lua b/packages/lest/src/lua/utils/serialise-value.lua
@@ -118,8 +118,13 @@ serialiseValue = function(value, visitedTables)
 			return "<circular reference>"
 		end
 
-		visitedTables[value] = true
-		return serialiseTable(value, visitedTables)
+		local visitedTablesCopy = {}
+		for k, v in pairs(visitedTables) do
+			visitedTablesCopy[k] = v
+		end
+		visitedTablesCopy[value] = true
+
+		return serialiseTable(value, visitedTablesCopy)
 	end
 
 	if type(value) == "function" then

diff --git a/packages/lest/src/lua/utils/tests/serialise-value.test.lua b/packages/lest/src/lua/utils/tests/serialise-value.test.lua
@@ -51,3 +51,12 @@ test("serialises table with circular reference", function()
 
 	expect(serialised).toBe('{bar = <circular reference>, foo = "123"}')
 end)
+
+test("serialises table with non-circular internal reference", function()
+	local tbl = { a = {}, b = { foo = "bar" } }
+	tbl.a.b = tbl.b
+
+	local serialised = serialiseValue(tbl)
+
+	expect(serialised).toBe('{a = {b = {foo = "bar"}}, b = {foo = "bar"}}')
+end)