squid:S1066 - Collapsible if statements should be merged #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,14 +404,12 @@ public void onTabSelected(ActionBar.Tab tab, FragmentTransaction fragmentTransac | |||
| } | |||
| } | |||
| } else if (checkTab(ViewPagerAdapter.INFO_FRAGMENT) && mChatService != null) { | |||
| if (mChatService.getState() == BluetoothChatService.STATE_CONNECTED) { | |||
|
@m-ezzat please see my inline comments. This PR actually does not compile: https://travis-ci.org/TKJElectronics/BalanduinoAndroidApp/builds/133403762. Is there any particular reason why you want to do all this? |
|
@Lauszus, I updated the PR, the reason is to fix the current code quality issues, as we agreed me & Mr.Thomas Kølbæk. Thanks for your notices! |
|
I am not sure whether you do not agree with these changes or not. Please close this PR if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1066 - Collapsible "if" statements should be merged
You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1066
Please let me know if you have any questions.
M-Ezzat