From e45d95fd334fa6508f604968b6ec3f0251ae396d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Sch=C3=A4fer?= <jan.schaefer@tngtech.com>
Date: Sun, 12 Apr 2015 09:19:30 +0200
Subject: [PATCH] fix some doclint errors and exclude impl package from javadoc
 output

---
 build.gradle                                                  | 4 ++++
 jgiven-core/src/main/java/com/tngtech/jgiven/DataTables.java  | 2 +-
 .../src/main/java/com/tngtech/jgiven/annotation/Table.java    | 3 +--
 .../src/main/java/com/tngtech/jgiven/base/StageBase.java      | 4 ++--
 .../java/com/tngtech/jgiven/report/ReportModelHandler.java    | 2 +-
 5 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/build.gradle b/build.gradle
index 82a4e83138..29a073db53 100644
--- a/build.gradle
+++ b/build.gradle
@@ -126,6 +126,10 @@ subprojects {
         }
    }
 
+   javadoc {
+        exclude '**/impl/**'
+   }
+
     checkstyle {
         configFile = file("${rootProject.projectDir}/develop/checkstyle-rules.xml")
         showViolations = false
diff --git a/jgiven-core/src/main/java/com/tngtech/jgiven/DataTables.java b/jgiven-core/src/main/java/com/tngtech/jgiven/DataTables.java
index cd3eedc03e..2084199462 100644
--- a/jgiven-core/src/main/java/com/tngtech/jgiven/DataTables.java
+++ b/jgiven-core/src/main/java/com/tngtech/jgiven/DataTables.java
@@ -11,7 +11,7 @@ public class DataTables {
 
     /**
      * Creates a table, i.e. a list of lists, with {@code numberOfColumns} columns from the given {@code data} including the header.
-     * <p/>
+     * <p>
      * Example:
      * <pre>{@code
      *     table(2,
diff --git a/jgiven-core/src/main/java/com/tngtech/jgiven/annotation/Table.java b/jgiven-core/src/main/java/com/tngtech/jgiven/annotation/Table.java
index 5789fa10f6..68eb114aab 100644
--- a/jgiven-core/src/main/java/com/tngtech/jgiven/annotation/Table.java
+++ b/jgiven-core/src/main/java/com/tngtech/jgiven/annotation/Table.java
@@ -105,7 +105,6 @@
      *     | b1 | b2 | b3 |
      *     | c1 | c2 | c3 |
      * </pre>
-     * </p>
      *
      * <h2>Effect on POJO lists</h2>
      * When the data is given by a list of POJOs then setting the header type to {@code VERTICAL} will also
@@ -116,7 +115,7 @@
      *         new CoffeeWithPrice("Espresso", 2.0),
      *         new CoffeeWithPrice("Cappuccino", 2.5)}
      * }</pre>
-     * When setting the header type to {@code VERTICAL}</br>
+     * When setting the header type to {@code VERTICAL}<br>
      * Then the report will present the following table
      * <pre>{@code
      *     | name         | Espresso | Cappuccino |
diff --git a/jgiven-core/src/main/java/com/tngtech/jgiven/base/StageBase.java b/jgiven-core/src/main/java/com/tngtech/jgiven/base/StageBase.java
index ee4779d580..d644df76b1 100644
--- a/jgiven-core/src/main/java/com/tngtech/jgiven/base/StageBase.java
+++ b/jgiven-core/src/main/java/com/tngtech/jgiven/base/StageBase.java
@@ -27,12 +27,12 @@ public SELF self() {
      * A step method for creating ad-hoc steps using lambdas.
      *
      * <h2>Example Usage</h2>
-     * <pre>
+     * <pre>{@code 
      *     given().$( "Two negative arguments", stage -> {
      *        stage.given().argument( -5 )
      *             .and().argument( -6 );
      *     });
-     * </pre>
+     * }</pre>
      *
      * @param description the description of the step
      * @param function the implementation of the step in form of a function where the parameter is the stage the step is executed in
diff --git a/jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportModelHandler.java b/jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportModelHandler.java
index 345a9a1d7c..2717d7caff 100644
--- a/jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportModelHandler.java
+++ b/jgiven-core/src/main/java/com/tngtech/jgiven/report/ReportModelHandler.java
@@ -29,7 +29,7 @@ public interface ReportModelHandler {
 
     /**
      * Is invoked when a scenario has multiple cases, but no data table.
-     * <p/>
+     * <p>
      * Plain Text Example:
      * <pre>
      *   Case 1: param1 = arg1, param2 = arg2