New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 1000 members extraction benchmark. #21

Merged

pietercolpaert merged 2 commits into TREEcg:main from xdxxxdx:main

Mar 22, 2024

Collaborator

xdxxxdx commented Mar 22, 2024

Requested by: #20

Extract4#ExtractionCollection1000Members is added to the tests.
1000 members are linked to a tree: Collection.

fix also the modification from the n3 Store to rdf-stores.

Function:

extract-cbd-shape/perf/perftest-outband.js

Line 118 in b11046e

const members = memberData.getQuads(null, "https://w3id.org/tree#member", null);

is written differently.
rdf-stores doesn't have bulk add function as n3 Stores addQuads() https://github.com/rubensworks/rdf-stores.js?tab=readme-ov-file#addquad, therefore the code is modified accordingly

xdxxxdx added 2 commits

March 22, 2024 14:25


          feat: 1000 members

2b6c835


          fix: reformat code

4bd5319

xdxxxdx requested review from pietercolpaert, kkostov and ajuvercr

March 22, 2024 14:09

xdxxxdx changed the title ~~feat: add 1000 members extraction benchmarking.~~ feat: add 1000 members extraction benchmark.

Member

pietercolpaert commented Mar 22, 2024

Both remarks: correct!

pietercolpaert merged commit 8672860 into TREEcg:main

1 check passed

xdxxxdx linked an issue

that may be closed by this pull request

Performance tests: Experiment with increasing page size #20

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet