Fix/Changes: Combobox callback fixes/changes #1073
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit comboboxes won't throw an error for a "nil" callback anymore. For some reason the game can not keep track of callbacks correctly anymore.
Also added a "oldValue" to the onSelect/onChange function of the combobox to ensure the previous set value is still sent.
I would happily have some people test this to see if I broke something or not and give their 2 cent on this.
Some things I'm not yet sure and maybe somebody has a better idea:
Related issue: #1068