Fix StudentenWerkMenuParser #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dates += [date] | ||
| return dates | ||
| @staticmethod | ||
| def extract_date_from_html(tree: html.Element) -> Optional[datetime.date]: |
There was a problem hiding this comment.
Python does not quite have a concept of public/private.
I can access private methods (those starting with __) without any problems from outside the module.
I might get a linting warning/.., but those can be ignored for tests
=> I would prefer the following and the comments can be removed. We can do this in a followup if you'd like
Suggested change
| def extract_date_from_html(tree: html.Element) -> Optional[datetime.date]: | |
| def __extract_date_from_html(tree: html.Element) -> Optional[datetime.date]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257 by using the overview instead of the daily details pages