Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Move php sniff to build dir #1357

Merged
merged 5 commits into from
Sep 17, 2024
Merged

[TASK] Move php sniff to build dir #1357

merged 5 commits into from
Sep 17, 2024

Conversation

lukaszuznanski
Copy link
Contributor

Part of: #1186

@lukaszuznanski lukaszuznanski changed the title [TASK] Move pph sniff to build dir [TASK] Move php sniff to build dir Jul 7, 2024
@lukaszuznanski lukaszuznanski self-assigned this Jul 7, 2024
oliverklee
oliverklee requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to adapt .gitattributes and the prepare-release Composer script.

oliverklee
oliverklee requested changes Jul 8, 2024
View reviewed changes
composer.json Show resolved Hide resolved
@lukaszuznanski
Copy link
Contributor Author

We also need to adapt .gitattributes and the prepare-release Composer script.

We remove whole Build dir, so only .gitattributes needs to be adapted.

@oliverklee
Copy link
Contributor

We remove whole Build dir, so only .gitattributes needs to be adapted.

I was thinking of removing this line that removes a file that will no longer exist after this PR:

"rm phpcs.xml",

Am I missing something here?

@lukaszuznanski
Copy link
Contributor Author

We remove whole Build dir, so only .gitattributes needs to be adapted.

I was thinking of removing this line that removes a file that will no longer exist after this PR:

"rm phpcs.xml",

Am I missing something here?

Yes, that's correct, that needs to be removed.

@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-php-sniff-to-build-dir branch from 3687fdf to 859167f Compare September 17, 2024 09:28
@oliverklee oliverklee added this to the 4.0.0: Breaking changes milestone Sep 17, 2024
oliverklee
oliverklee requested changes Sep 17, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@lukaszuznanski @oliverklee
Update composer.json
fdf1197 
Co-authored-by: Oliver Klee <typo3-coding@oliverklee.de>
@oliverklee oliverklee merged commit ac8c124 into main Sep 17, 2024
55 checks passed
@oliverklee oliverklee deleted the TASK/Move-php-sniff-to-build-dir branch September 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@lukaszuznanski lukaszuznanski

Labels
cleanup make the extension conform to the best practices
Projects
None yet
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszuznanski @oliverklee