149 release version with plonk support #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
0xThemis
force-pushed
the
149-release-version-with-plonk-support
branch
from
e53e81a
to
63fd4cf
Compare
|
The updates to the md book will be on a dedicated PR - it is easier to test if the changes were already merged on main |
dkales
requested changes
Aug 13, 2024
0xThemis
force-pushed
the
149-release-version-with-plonk-support
branch
2 times, most recently
from
fc0bb6b
to
eef2581
Compare
dkales
previously approved these changes
Aug 14, 2024
BREAKING CHANGE: renamed the method from_reader_unchecked and from_reader_unchecked_for_zkey to better names showing were to use them
BREAKING CHANGE: moved common code for PLONK and Groth16 into separate crate. Most notably the SharedWitness and SharedInput
0xThemis
force-pushed
the
149-release-version-with-plonk-support
branch
from
eef2581
to
699f400
Compare
BREAKING CHANGE: to unify Groth16 and PLONK we now take the zkey as ref in PLONK when calling prove
0xThemis
force-pushed
the
149-release-version-with-plonk-support
branch
from
699f400
to
7aa5c4e
Compare
dkales
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesnt close 140 anymore - we moved it to other PR
closes #141
closes #142