Upgrade to .net6 #42
Open
Upgrade to .net6 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update Target Framework to .net6. 2. Update dependency package. 3. Update the method which is no longer in new version of the package.
Bogatinov
reviewed
Apr 18, 2024
| <PackageReference Include="SixLabors.ImageSharp" Version="2.1.1" /> | ||
| <PackageReference Include="SixLabors.ImageSharp.Drawing" Version="1.0.0-beta14" /> | ||
| <PackageReference Include="SixLabors.Fonts" Version="1.0.1" /> | ||
| <PackageReference Include="SixLabors.ImageSharp" Version="2.1.6" /> |
Bogatinov
reviewed
Apr 18, 2024
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <TargetFrameworks>net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
this breaks .NET Framework compatibility
https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0
Possible to use netstandard2.0 while also supporting the new SixLabors libs?
There was a problem hiding this comment.
Hi @Bogatinov , Thanks for comment, I will check netstandard2.0 is supporting the new SixLabors libs or not and do a necessary update on it.
There was a problem hiding this comment.
Hi @tommyliew-machines I checked it out
SixLabors.Fonts 1.0.1works onnetstandard2.0, but2.0.0isnet6.0dependentSixLabors.ImageSharp.Drawing 1.0.0works onnetstandard2.0, but2.0.0isnet6.0dependentSixLabors.ImageSharp 2.1.8is the last version that allowsnetstandard2.0
I can open a PR and update the libraries
- SixLabors.Fonts 1.0.1
- SixLabors.ImageSharp.Drawing 1.0.0
- SixLabors.ImageSharp 2.1.8
- and any methods that are different between Beta version
Then we can do 2 changes
- my PR to offer a small bump in v1.7.1.1, which is still compliant with
netstandard2.0 - this PR to offer update to v2.0.0 which will break net48 compatibility = if Author is okay with that decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Due to IronPDF version 2023.10.3 is using SixLabors version 1.0.0 and above, caused conflict with NetBarcode version and throwed exception of Method missing.