Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "spring-data-bom was updated to 2021.2.16 so override is nog l… #603

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

matthijsln
Copy link
Contributor

…onger necessary"

This reverts commit 32cae90.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Test Results

228 tests  ±0   226 ✔️ +1   3m 47s ⏱️ -17s
  19 suites ±0       2 💤 ±0 
  19 files   ±0       0  - 1 

Results for commit 91a486e. ± Comparison against base commit c77f6e2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems odd that the bug (spring-projects/spring-data-rest#2287) is reportedly fixed in 3.7.16 / 2021.2.16 which is part of spring-boot 2.7.16 (https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/2.7.16/spring-boot-dependencies-2.7.16.pom) look for spring-data-bom.version through https://central.sonatype.com/artifact/org.springframework.data/spring-data-bom/2021.2.16

But there are other reports that the problem is not fixed: spring-projects/spring-data-rest#2280

In any case the comment that describes why and when fixed does not hold.

@matthijsln
Copy link
Contributor Author

matthijsln commented Oct 5, 2023

But there are other reports that the problem is not fixed: spring-projects/spring-data-rest#2280

Yeah seems the problem is still there, so best to stay on 3.7.12 I guess.

In any case the comment that describes why and when fixed does not hold.

Updated comment.

@matthijsln matthijsln requested a review from mprins October 5, 2023 13:48
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #603 (91a486e) into main (c77f6e2) will increase coverage by 73%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #603     +/-   ##
=======================================
+ Coverage       6%    78%    +73%     
  Complexity     77     77             
=======================================
  Files          79     79             
  Lines        3605   3605             
  Branches      359    359             
=======================================
+ Hits          189   2789   +2600     
+ Misses       3397    626   -2771     
- Partials       19    190    +171     

see 73 files with indirect coverage changes

@mprins mprins added bug Something isn't working dependency (automated) dependency update labels Oct 5, 2023
@mprins mprins merged commit d100331 into main Oct 5, 2023
5 checks passed
@mprins mprins deleted the revert-to-HTM-908-workaround branch October 5, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependency (automated) dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants