Nitpicks from clang-scan #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the nitpicks in tarsnap code, not including the false positives (discussed in #527). There's a lot more nitpicks in libarchive code. I'll prepare a separate branch for (some of?) those, although my first guess is that we won't want to merge it due to diverting from libarchive. |
|
Actually, I think some of the libarchive changes are worth doing, so I'll add them here when they're ready. |
Compilers and static analysis tools can't work out that sp is always
non-NULL when we use it, due to the combination of:
for (h = 0; h < sleepers_getsize(sleepers); h++) {
sp = *sleepers_get(sleepers, h);
...
}
if (h == sleepers_getsize(sleepers)) {
...
}
/* Use sp. */
Reported by: gcc, clang, clang scan-build
archive_read_format_tar_read_advance() is not part of libarchive (it's a tarsnap-specific addition). Reported by: clang scan-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.