Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mock implementations from src into a test folder #210

Open
vzahradnik opened this issue Sep 7, 2024 · 2 comments
Open

Move mock implementations from src into a test folder #210

vzahradnik opened this issue Sep 7, 2024 · 2 comments
Labels

Comments

@vzahradnik
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Main library source contains mock implementations of the library. We should move them into test repository or elsewhere, to clearly separate them from the remaining code.

@davetcc
Copy link
Collaborator

davetcc commented Sep 15, 2024

We can't really do that because they are used externally to the project (IE in TcMenu and other projects) so they need to be on the path.

@vzahradnik
Copy link
Collaborator Author

OK, can we keep this issue open and focus on improving the other projects to not use these resources? If you think the code has to stay there and there is no way how to refactor, you can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants