Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

게시판 state 리코일로 변경 #27

Merged
merged 3 commits into from
Jul 2, 2023
Merged

게시판 state 리코일로 변경 #27

merged 3 commits into from
Jul 2, 2023

Conversation

Ubinquitous
Copy link
Member

작업사항

  • 카테고리와 게시판 필터를 상위 컴포넌트에서도 값을 핸들링할 수 있게 하기 위해 리코일로 state를 바꿔주었습니다.
  • 게시판 필터를 hover했을 때 글자가 서서히 커지는 애니메이션을 추가했습니다.

@Ubinquitous Ubinquitous added enhancement New feature or request refactor refactoring code labels Jul 2, 2023
@Ubinquitous Ubinquitous requested review from J1min and 5ewon July 2, 2023 14:19
@Ubinquitous Ubinquitous self-assigned this Jul 2, 2023
J1min
J1min reviewed Jul 2, 2023
View reviewed changes
Copy link
Member

@J1min J1min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
앞으로 이런 세팅은 굳이 리뷰 안받아도 될거같습니다~

@Ubinquitous
Copy link
Member Author

확인했습니다 감사합니다!

@Ubinquitous Ubinquitous merged commit 0e12c98 into main Jul 2, 2023
1 check passed
@Ubinquitous Ubinquitous changed the title Refactor/recoil 게시판 state 리코일로 변경 Jul 2, 2023
@Ubinquitous Ubinquitous deleted the refactor/recoil branch November 27, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J1min J1min J1min left review comments

@5ewon 5ewon Awaiting requested review from 5ewon

Assignees

@Ubinquitous Ubinquitous

Labels
enhancement New feature or request refactor refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ubinquitous @J1min