시간표 페이지 퍼블리싱 #36
Merged
시간표 페이지 퍼블리싱 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J1min
reviewed
Jul 20, 2023
package.json
Outdated
| @@ -25,6 +25,7 @@ | |||
| "eslint-config-next": "13.0.0", | |||
| "eslint-plugin-prettier": "^4.2.1", | |||
| "jest": "^29.3.1", | |||
| "moment": "^2.29.4", | |||
There was a problem hiding this comment.
moment 대신 요즘 더 많이 쓰이고 최적화도 더 야무진 dayjs 추천합니다
https://blog.hoseung.me/2022-03-13-dayjs-instead-of-momentjs/
J1min
reviewed
Jul 20, 2023
| import SVGAttribute from "@/global/types/SVGAttribute"; | ||
| import React from "react"; | ||
|
|
||
| const DownArrow = ({ width, height }: SVGAttribute) => { |
There was a problem hiding this comment.
개인적으로 얘는 특별히 4방향으로 회전할 수 있는 옵션이 props에 있으면 멋질 것 같습니다!
|
반영 완료했습니다 감사합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
하면서 제일 힘들었던 PR입니다^^... 퍼블리셔도 쉽지 않은 직업이라는 것을 알게 되었습니다..
아직 API가 연결되지 않아 직간접적으로 현재 시간과 동기화 기능을 구현하지 못했습니다.
임시로 작성한 코드가 있으니 감안하고 봐주시면 감사하겠숩니다..
변경한 점
일정표 페이지, 즉 shedule 페이지에서 shedule보단 calender라는 단어가 조금 더 적합한 것으로
판단해 컴포넌트와 페이지, 라우터명을 전부 calender로 바꾸었습니다.
스크린샷