🔀 :: 독서 상세페이지 퍼블리싱 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kimkyumbi
reviewed
Apr 19, 2024
| .init(text: "삭제", style: .default) { } | ||
| ] | ||
| ) | ||
| .mindWayBottomSheet(isShowing: $viewModel.isShowingBottomSheet) { |
There was a problem hiding this comment.
Suggested change
| .mindWayBottomSheet(isShowing: $viewModel.isShowingBottomSheet) { | |
| .mindWayBottomSheet( | |
| isShowing: $viewModel.isShowingBottomSheet | |
| ) { |
There was a problem hiding this comment.
요소가 하나밖에 안들어가서 굳이 줄바꿈 할 필요 없을 것 같아요~.~
| set: { _ in} | ||
| ) | ||
| ) { | ||
|
|
There was a problem hiding this comment.
#warning 이나 // TODO: - ~~ 추가하면 나중에 더 확실하게 할 수 있을 것 같아요!
There was a problem hiding this comment.
이미 만들어놔서 머지 되면 바로 pr 올릴 예정입니다!
| .padding(.top, -20) | ||
| .padding(.horizontal, 24) | ||
| .toolbar { | ||
| ToolbarItemGroup(placement: .navigationBarTrailing) { |
There was a problem hiding this comment.
ToolbarItem으로 해도 되지 않나요? Group인데 요소는 하나밖에 안들어갔으니까요
|
영상에서 확인 버튼을 눌렀을 때 텍스트필드가 번쩍이는 건 어떻게 못하나요? |
Xixn2
approved these changes
Apr 19, 2024
수정했어요 영상 다시 확인해주세요~! |
kimkyumbi
reviewed
Apr 19, 2024
Comment on lines
87
to
89
| #Preview { | ||
| BookOrderView(viewModel: BookOrderViewModel()) | ||
| } |
kimkyumbi
reviewed
Apr 19, 2024
Comment on lines
116
to
118
| #Preview { | ||
| BookDetailView(viewModel: BookDetailViewModel()) | ||
| } |
확인했습니다 |
kimkyumbi
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
독서 상세페이지 퍼블리싱
📃 작업내용
독서 상세페이지를 퍼블리싱했어요
DesignSystem에 MindWayAlert를 추가했어요
DesignSystem ButtonStyle에 cancel 버튼을 추가했어요
DesignSystem extension에 navigate를 추가했어요
BookOrderView에서 자체적으로 만든 alert을 삭제하고 MindWayAlert로 변경해주었어요
🎸 기타
수정페이지는 따로 pr 올릴 예정이에요!
2024-04-19.3.33.54.mov