#7 [ui] 온보딩 - 테마 선택 뷰 #12

emjayMJkim · 2024-01-09T09:37:25Z

📑 Work Description

온보딩 activity 생성
테마 선택 뷰 ui 구현

🛠️ Issue

closed [ui] onBoarding - 루틴 선택 #7

📷 Screenshot

ui.onboarding-theme.choice.webm

💬 To Reviewers

테마 3개 이상 선택 시 버튼 활성화 로직은 다음 pr에 반영하겠습니다

stellar-halo

고생했어요! 덕분에 이 부분 편하게 하겠네요!!

stellar-halo · 2024-01-09T09:40:46Z

app/src/main/java/com/sopetit/softie/domain/entity/Theme.kt

+package com.sopetit.softie.domain.entity
+
+data class Theme(


stellar-halo · 2024-01-09T09:48:20Z

app/src/main/java/com/sopetit/softie/ui/onboarding/OnboardingActivity.kt

+        viewModel.bearNameChoiceView.observe(this) {
+            if (it) {
+                changeFragment(SetBearNameFragment())
+            }


viewModel.bearNameChoiceView.observe(this) { bearNameChoiceView -> if (bearNameChoiceView) { changeFragment(SetBearNameFragment()) } }

이런 건 어떤가요?

이렇게 하는 게 더 가독성이 높아질 것 같네요!!

stellar-halo · 2024-01-09T09:49:06Z

app/src/main/java/com/sopetit/softie/ui/onboarding/OnboardingViewModel.kt

+    fun changeThemeChoiceView() {
+        _themeChoiceView.value = true
+    }


다른 view 값들에 대해서는 false 처리를 안해도 나중에 문제가 안될지,,!!

온보딩 과정 중에는 뒤로가기 버튼을 막아야 되겠죠..?

저도 고민을 좀 했는데.. 일단은 지금 온보딩 과정 중에 뒤로가기 로직이 없는 상태라서 그냥 true로만 설정했습니다...! 나중에 유저 로직이 바뀌게 되면 코드 수정하겠습니당

stellar-halo · 2024-01-09T09:50:32Z

app/src/main/java/com/sopetit/softie/ui/onboarding/themechoice/ChoiceThemeFragment.kt

+                    5,
+                    8,


매직 넘버 말고 companion로 빼주실 수 있을까요?!

네엡!! 이걸 pr 올리고 발견했네요..

stellar-halo · 2024-01-09T09:51:29Z

app/src/main/java/com/sopetit/softie/ui/onboarding/themechoice/ChoiceThemeViewModel.kt

+            Theme(
+                1,
+                "하루의 시작",
+                "",
+                ""


꼼꼼한 가짜 데이터,,,

stellar-halo · 2024-01-09T09:55:33Z

app/src/main/res/layout/activity_onboarding.xml

+                android:layout_marginTop="28dp"
+                android:src="@{viewModel.themeChoiceView ? @drawable/shape_main1_fill_99_rect : @drawable/shape_gray100_fill_99_rect}"
+                app:layout_constraintTop_toTopOf="parent"


Top_toTopOf="@id/iv_onboarding_top_bar_second"
으로 걸면 marginTop을 안해도 되니 적용해보시는 건 어떤가요

제가 아무 생각 없이 복사 붙여넣기 하고 코드를 안 고쳤군요.. 감사합니다!!

stellar-halo · 2024-01-09T09:58:15Z

app/src/main/res/layout/fragment_onboarding_choice_theme.xml

+            app:layout_constraintEnd_toEndOf="@id/iv_onboarding_choice_theme_speech_background" />
+
+        <androidx.recyclerview.widget.RecyclerView
+            android:id="@+id/rcv_onboarding_choice_theme"


"@+id/rv_onboarding_choice_theme"
로 바꿔주세요!

stellar-halo · 2024-01-09T10:00:21Z

app/src/main/res/values/colors.xml

+    <!-- onboarding -->
+    <color name="onboarding_speech">#FF259560</color>


아앗,,제가 빼먹었군요

minemi00

배울점이 많은 코드네요 보고 고쳐야겠습니다 수고하셨서요!

minemi00 · 2024-01-09T10:13:52Z

app/src/main/res/layout/activity_onboarding.xml

+                android:layout_height="6dp"
+                android:layout_marginTop="28dp"
+                android:layout_marginStart="20dp"
+                android:src="@{viewModel.bearChoiceView ? @drawable/shape_main1_fill_99_rect : @drawable/shape_gray100_fill_99_rect}"


데이터바인딩 활용 잘한다!

minemi00 · 2024-01-09T10:17:01Z

app/src/main/res/layout/fragment_onboarding_choice_theme.xml

+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/iv_onboarding_choice_theme_title_bear"
+            app:layout_constraintBottom_toTopOf="@id/btn_onboarding_choice_theme"
+            tools:listitem="@layout/item_onboarding_choice_theme" />


리사이클러뷰 아이템 개수를 굳이 설정 안해도 되는군요

저 같은 경우에는 그리드 레이아웃으로 12개로 아이템이 정해져 있습니다!

minemi00 · 2024-01-09T10:18:08Z

app/src/main/res/layout/item_onboarding_choice_theme.xml

+        android:layout_width="40dp"
+        android:layout_height="40dp"
+        android:src="@drawable/ic_theme_1"
+        app:layout_constraintTop_toTopOf="@id/iv_theme_background"


아 부모를 백그라운드로 설정하면 안에다가 이미지뷰 들어가지,,, 바꿔야겠다

pump9918

글자 인덱싱하는 법 잘 알아갑니다~
개인적으로 글자가 유연하게 길어지거나 줄어들 때 상대 위치로도 인덱싱 가능한지 궁금하네요

pump9918 · 2024-01-09T09:43:19Z

app/src/main/res/layout/activity_onboarding.xml

+                android:layout_height="6dp"
+                android:layout_marginTop="28dp"
+                android:layout_marginEnd="20dp"
+                android:src="@{viewModel.routineChoiceView ? @drawable/shape_main1_fill_99_rect : @drawable/shape_gray100_fill_99_rect}"


리드님이 좋아하는 삼항연산자...

pump9918 · 2024-01-09T10:14:35Z

app/src/main/res/layout/fragment_onboarding_choice_theme.xml

+            android:layout_marginVertical="14dp"
+            android:text="@string/onboarding_choice_theme_speech"
+            android:textColor="@color/gray700"
+            android:textAppearance="@style/bubble16"


style:"@~" 와 같이 적는거보다 textAppearance가 더 일반적인 사용법인가요?

더 일반적이기 보다는 제 습관입니다..!!

pump9918 · 2024-01-09T10:17:58Z

app/src/main/java/com/sopetit/softie/ui/onboarding/themechoice/ChoiceThemeFragment.kt

+        binding.viewModel = viewModel
+
+        binding.tvOnboardingChoiceThemeSpeech.text =
+            SpannableStringBuilder(getString(R.string.onboarding_choice_theme_speech)).apply {


setSpan이 멘트의 특정부분만 인덱싱해서 색을 바꾸는 부분인가요?
잘 배워갑니다...

네! 이렇게 하면 textview를 여러개 만들 필요가 없습니당

m1njae · 2024-01-09T10:56:29Z

민정쌤 좀 치시네요 고생하셨습니다!

emjayMJkim added 10 commits January 9, 2024 13:00

#7 [add] 온보딩 top bar drawable 파일 생성

f0f2b67

#7 [add] OnboardingActivity 생성

3a819da

#7 [add] fragment에서 fragment 전환 구현

69c6e6a

#7 [add] 온보딩 뷰 모든 fragment 전환 구현

fb74ae9

#7 [del] 필요없는 파일 삭제

d8201c9

#7 [chore] viewModel 파일 위치 이동

36a401c

#7 [ui] 온보딩 - 테마 선택 xml 구현

b4d2a00

#7 [feat] 테마 선택 recyclerview 구현

719cc79

#7 [fix] merge conflict 해결

83c9c68

#7 [ui] 말풍선 text spannable 설정

16668f7

emjayMJkim requested review from stellar-halo, pump9918 and minemi00 January 9, 2024 09:37

emjayMJkim self-assigned this Jan 9, 2024

emjayMJkim added UI ui 관련 작업 민정🦊 민정이가 작업함! labels Jan 9, 2024

emjayMJkim added 2 commits January 9, 2024 18:41

#7 [mod] ktlint 정렬

c874cfa

#7 [fix] CI 오류 해결

e53dc90

stellar-halo requested changes Jan 9, 2024

View reviewed changes

minemi00 approved these changes Jan 9, 2024

View reviewed changes

pump9918 approved these changes Jan 9, 2024

View reviewed changes

#7 [mod] 코드 리뷰 반영 코드 수정

4efc7db

stellar-halo approved these changes Jan 9, 2024

View reviewed changes

emjayMJkim merged commit 22d97ac into develop Jan 9, 2024
1 check passed

emjayMJkim deleted the feature/#7-onboarding-choice-routine branch January 9, 2024 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#7 [ui] 온보딩 - 테마 선택 뷰 #12

#7 [ui] 온보딩 - 테마 선택 뷰 #12

emjayMJkim commented Jan 9, 2024

stellar-halo left a comment

stellar-halo Jan 9, 2024

stellar-halo Jan 9, 2024

emjayMJkim Jan 9, 2024

stellar-halo Jan 9, 2024

emjayMJkim Jan 9, 2024

stellar-halo Jan 9, 2024

emjayMJkim Jan 9, 2024

stellar-halo Jan 9, 2024

stellar-halo Jan 9, 2024

emjayMJkim Jan 9, 2024

stellar-halo Jan 9, 2024 •

edited

Loading

emjayMJkim Jan 9, 2024

stellar-halo Jan 9, 2024

minemi00 left a comment

minemi00 Jan 9, 2024

minemi00 Jan 9, 2024

emjayMJkim Jan 9, 2024

minemi00 Jan 9, 2024

pump9918 left a comment

pump9918 Jan 9, 2024

pump9918 Jan 9, 2024

emjayMJkim Jan 9, 2024

pump9918 Jan 9, 2024

emjayMJkim Jan 9, 2024

m1njae commented Jan 9, 2024

		<!-- onboarding -->
		<color name="onboarding_speech">#FF259560</color>

#7 [ui] 온보딩 - 테마 선택 뷰 #12

#7 [ui] 온보딩 - 테마 선택 뷰 #12

Conversation

emjayMJkim commented Jan 9, 2024

📑 Work Description

🛠️ Issue

📷 Screenshot

💬 To Reviewers

stellar-halo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-halo Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minemi00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pump9918 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m1njae commented Jan 9, 2024

stellar-halo Jan 9, 2024 •

edited

Loading