#27 [feat] 스플래쉬 구현 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeun5744
reviewed
Jan 10, 2024
Comment on lines
22
to
24
| val versionList: List<Int> = listOf(1, 2, 3, 4) | ||
|
|
||
| when (versionList.random()) { |
There was a problem hiding this comment.
Suggested change
| val versionList: List<Int> = listOf(1, 2, 3, 4) | |
| when (versionList.random()) { | |
| when (Random.nextInt(1, 5)) { |
코드 일케 줄일수 있을거 같네요 ㅎㅎ
Comment on lines
32
to
41
| private fun initMakeFragment(fragmentVersion: Fragment) { | ||
| val currentFragment = supportFragmentManager.findFragmentById(R.id.fcv_splash) | ||
| if (currentFragment == null) { | ||
| supportFragmentManager.beginTransaction() | ||
| .add(R.id.fcv_splash, fragmentVersion) | ||
| .commit() | ||
| } | ||
|
|
||
| initMakeSplash() | ||
| } |
There was a problem hiding this comment.
개인적으로 fragment 보다는,BindingActivity 대신 AppCompatActivity() 를 상속받은 후 랜덤으로 setContentView를 설정해서 구현하는걸 추천드려요!!!
minemi00
approved these changes
Jan 11, 2024
| import com.sopetit.softie.databinding.FragmentSplashVersionThirdBinding | ||
| import com.sopetit.softie.util.binding.BindingFragment | ||
|
|
||
| class SplashVersionThirdFragment : |
There was a problem hiding this comment.
스플래시 프래그먼트를 다 따로 만들어서 해주면 되는군요!
There was a problem hiding this comment.
이 부분은 이미지로 바꾸기로 했습니당.. ㅎㅎ 코드 수정할께요!
pump9918
approved these changes
Jan 11, 2024
| initCreateRandomVersion() | ||
| } | ||
|
|
||
| private fun initCreateRandomVersion() { |
There was a problem hiding this comment.
ㅋㅋㅋㅋ 생각보다 안 어렵더라구요 ㅎㅎ
| }, SPLASH_DELAY) | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
Delay 값을 수기로 넣는 것보다 빼놓는 것이 좋은가요?
There was a problem hiding this comment.
일단 매직 넘버를 그냥 써 주는 것보다 companion object 내에 상수로 선언하게 되면 각 값들이 어떤 것을 의미하는 지 파악하기 쉬워집니당
stellar-halo
approved these changes
Jan 11, 2024
Comment on lines
+23
to
+26
| 1 -> makeSplashImg(R.drawable.ic_splash1) | ||
| 2 -> makeSplashImg(R.drawable.ic_splash2) | ||
| 3 -> makeSplashImg(R.drawable.ic_splash3) | ||
| 4 -> makeSplashImg(R.drawable.ic_splash4) |
There was a problem hiding this comment.
훨씬 리소스가 간단한 것 같아 좋은 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
feat.splash.login.mp4
💬 To Reviewers
일단 로그인 뷰 생성해서 카카오 로그인 버튼 클릭시
StoryTellingActivity로 넘어가도록 했습니다