#19 [ui] 데일리 루틴 뷰 구현 #34

minemi00 · 2024-01-10T18:59:14Z

📑 Work Description

데일리 루틴뷰 구현 완
데일리 루틴 편집 뷰 로직 빼고 완

🛠️ Issue

closed [ui] 데일리 루틴 - 엠티뷰 및 추가된 뷰 #18 #19

📷 Screenshot

Screen_recording_20240111_143710.mp4

💬 To Reviewers

activity_sample 만들고 DailyRoutineActivity라는 가짜 액티비티 만들어서 확인해줬습니다.
편집 뷰에서 클릭한 개수대로 버튼 n개 삭제하기 텍스트 포함해서 편집용 브랜치에다가 로직 완성하겠습니다.

…roid into feature/#19-daily-routine

stellar-halo

아자아자 화이팅!! 할 수 있다
GONE의 세계로,,

stellar-halo · 2024-01-10T19:02:39Z

app/src/main/java/com/sopetit/softie/ui/userdaily/DailyEditActivity.kt

+        }
+    }
+
+    private var isBtnSelected = false


변수는 항상 class의 맨 상단에 주시면 됩니다!

stellar-halo · 2024-01-10T19:24:20Z

app/src/main/java/com/sopetit/softie/ui/userdaily/DailyEditActivity.kt

+                isBtnSelected = !isBtnSelected
+                btnRadioEmpty.isSelected = isBtnSelected
+            }
+            btnRadioEmptySecond.setOnClickListener {
+                isBtnSelected = !isBtnSelected
+                btnRadioEmptySecond.isSelected = isBtnSelected
+            }
+            btnRadioEmptyThird.setOnClickListener {
+                isBtnSelected = !isBtnSelected
+                btnRadioEmptyThird.isSelected = isBtnSelected


위의 변수를 공용으로 사용하고 있네요!

btnRadioEmpty.isSelected = !btnRadioEmpty.isSelected

이런식으로 바꿔주세요~!

stellar-halo · 2024-01-10T19:24:52Z

app/src/main/java/com/sopetit/softie/ui/userdaily/DailyEmptyFragment.kt

+import com.sopetit.softie.databinding.FragmentDailyEmptyBinding
+import com.sopetit.softie.util.binding.BindingFragment
+
+class DailyEmptyFragment :


Empty보다는 DailyRoutineFragment가 좀 더 어울려 보입니다!

stellar-halo · 2024-01-10T19:25:30Z

app/src/main/java/com/sopetit/softie/ui/userdaily/DailyEditActivity.kt

+import com.sopetit.softie.databinding.ActivityDailyEditBinding
+import com.sopetit.softie.util.binding.BindingActivity
+
+class DailyEditActivity : BindingActivity<ActivityDailyEditBinding>(R.layout.activity_daily_edit) {


DailyRoutineEditActivity는 어떤가요!
변수명이나 class명이 더 길어도 좋으니 명확하게 설명해주는 것이 좋아보입니다!

stellar-halo · 2024-01-10T19:26:57Z

app/src/main/java/com/sopetit/softie/ui/userdaily/DailyEmptyViewModel.kt

+class DailyEmptyViewModel : ViewModel() {
+    val routineAddList = listOf<Int>(1)
+
+    companion object {
+        const val NONE = 0
+        const val FIRST_ROUTINE = 1
+        const val SECOND_ROUTINE = 2
+        const val THIRD_ROUTINE = 3
+        const val FOURTH_ROUTINE = 4
+        const val MAX_ROUTINE = 3
+    }


empty fragment가 daily activity에 종속된 것이 아니니 viewModel을 분리해주세요!

stellar-halo · 2024-01-10T19:28:50Z

app/src/main/res/layout/activity_daily_edit.xml

+            app:layout_constraintTop_toTopOf="parent" />
+
+        <TextView
+            android:id="@+id/tv_cancel"


마찬가지입니다~ id 컨벤션 지켜주세요!

stellar-halo · 2024-01-10T19:29:04Z

app/src/main/res/layout/activity_daily_edit.xml

+            app:layout_constraintTop_toTopOf="@id/tv_daily_routine" />
+
+        <View
+            android:id="@+id/v_blank"


stellar-halo · 2024-01-10T19:30:38Z

app/src/main/res/layout/activity_daily_edit.xml

+            app:layout_constraintEnd_toEndOf="parent"
+            android:background="@drawable/shape_red_fill_12_rect"
+            app:layout_constraintBottom_toBottomOf="parent" />
+


공백이 두 줄이네요 한 줄 삭제해주세요~

stellar-halo · 2024-01-10T19:33:53Z

app/src/main/res/layout/activity_daily_edit.xml

+        <androidx.appcompat.widget.AppCompatButton
+            android:id="@+id/btn_delete"
+            android:layout_width="0dp"
+            android:layout_height="57dp"


저는 고정 dp 보다는 height = "0dp"를 쓰고
paddingTop, paddingBottom을 이용하는 걸 더 선호하기는 합니다!

stellar-halo · 2024-01-10T19:34:54Z

app/src/main/res/values/strings.xml

+    <string name="daily_edit_delete">n개 삭제</string>
+    <string name="daily_edit_routine_name">데일리 루틴</string>
+    <string name="daily_edit_cancel">취소</string>
+    <string name="daily_routine_user_add">이불 개기</string>
+    <string name="daily_routine_ing">n번째 달성 중</string>
+    <string name="daily_routine_fin_btn">완료하기</string>
+    <string name="daily_routine_fin">달성완료</string>
+    <string name="daily_edit">편집</string>


뷰마다 분리해주세요!

string 변수명도 변경 부탁드립니다~

…roid into feature/#19-daily-routine # Conflicts: # app/src/main/res/values/strings.xml

stellar-halo · 2024-01-11T06:16:39Z

app/src/main/java/com/sopetit/softie/ui/dailyroutine/DailyRoutineViewModel.kt

+        const val NONE = 0
+        const val FIRST_ROUTINE = 1
+        const val SECOND_ROUTINE = 2
+        const val THIRD_ROUTINE = 3
+        const val FOURTH_ROUTINE = 4


너무 잦은 companion object는 좋지 않습니다!
companion object에서 const val는 컴파일 시에 초기화 되기 때문에 싱글톤으로 사용할 수 있는데,
위와 같은 변수들은 쓰이지 않을 가능성이 크며 다른 화면에서 필요해 보이지 않습니다! => companion으로 분류할 필요가 없어보입니다~

저도 무작정 썼는데 잘 배워갑니다!

stellar-halo · 2024-01-11T06:17:31Z

app/src/main/res/values/strings.xml

+    <!-- doll selection -->
+    <string name="doll_selection_question">어떤 친구와 함께 할까요?</string>
+    <string name="doll_selection_subtitle">한 번 선택한 인형은 바꿀 수 없어요</string>
+    <string name="doll_selection_button">이 친구와 함께 할래</string>


이 부분이 아마 bear selection으로 바뀌면서 잘못 merge된 거 같네요!

pump9918

올라가라~~

…roid into feature/#19-daily-routine # Conflicts: # app/src/main/res/drawable/shape_red_fill_12_rect.xml

emjayMJkim

진짜 수고하셨습니다!!

emjayMJkim · 2024-01-11T06:31:18Z

app/src/main/res/drawable/shape_white_fill_20_rect.xml

+    <corners android:radius="20dp"/>
+    <solid android:color="@color/white"/>
+    <stroke android:color="@color/gray100"
+        android:width="1dp"/>


solid, stroke 색 다른 경우에는 파일명 shape_white_fill_gray100_stroke_20_rect 으로 바꿔주세요!

emjayMJkim · 2024-01-11T06:32:12Z

...rc/main/java/com/sopetit/softie/ui/dailyroutine/dailyroutineedit/DailyRoutineEditActivity.kt

+        }
+    }
+
+    private fun setButtonClickListener(button: View) {


함수화 좋아요~~

minemi00 added 11 commits January 10, 2024 16:30

[ui] 데일리루틴 엠티뷰 빈 박스 만들기

fcbcde5

[ui] 데일리루틴 달성완료 박스 만들기

121c7f4

Merge branch 'develop' of https://github.com/Team-Sopetit/Sopetit-And…

cd20751

…roid into feature/#19-daily-routine

[ui] 리스트 개수별 상자 띄우기

15ff717

[ui] 라디오버튼 셀렉터 만들기

6d2cc9f

[ui] 상자 간격 문제 해결

a27312a

[ui] 데일리루틴 삭제 뷰 작업

9fbf126

[ui] 확인용 액티비티 만들기

361d6c5

[add] string 추출하기

1a198aa

[chore] manifest에 액티비티 추가

fc539e7

Merge branch 'develop' of https://github.com/Team-Sopetit/Sopetit-And…

b5480a1

…roid into feature/#19-daily-routine

minemi00 added UI ui 관련 작업 민회🐹 민회가 작업함! labels Jan 10, 2024

minemi00 requested review from stellar-halo, pump9918 and emjayMJkim January 10, 2024 18:59

minemi00 self-assigned this Jan 10, 2024

minemi00 added 2 commits January 11, 2024 04:24

[chore] 상단바 안보이게 수정하기

057eab6

[refact] 라디오버튼 셀렉트 리팩토링

ec98ae8

stellar-halo requested changes Jan 10, 2024

View reviewed changes

minemi00 added 6 commits January 11, 2024 13:35

[chore] 폴더링 및 네이밍 수정

d3dee0c

[chore] 폴더링 및 네이밍 한번 더 수정

21c90c2

[add] 데일리루틴 뷰모델이랑 편집 뷰모델 분리

207d04c

[chore] manifest 돌려놓기

c56d07d

[chore] 삭제 비활성화 버튼 추가 및 버튼 패딩 수정

1a772e5

Merge branch 'develop' of https://github.com/Team-Sopetit/Sopetit-And…

f2a247b

…roid into feature/#19-daily-routine # Conflicts: # app/src/main/res/values/strings.xml

stellar-halo approved these changes Jan 11, 2024

View reviewed changes

[chore] 코드리뷰 반영

31d99f6

pump9918 approved these changes Jan 11, 2024

View reviewed changes

Merge branch 'develop' of https://github.com/Team-Sopetit/Sopetit-And…

09d6019

…roid into feature/#19-daily-routine # Conflicts: # app/src/main/res/drawable/shape_red_fill_12_rect.xml

emjayMJkim approved these changes Jan 11, 2024

View reviewed changes

[chore] 파일명 변경

95c084d

minemi00 merged commit 45b4eac into develop Jan 11, 2024
1 check passed

minemi00 deleted the feature/#19-daily-routine branch January 11, 2024 06:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#19 [ui] 데일리 루틴 뷰 구현 #34

#19 [ui] 데일리 루틴 뷰 구현 #34

minemi00 commented Jan 10, 2024 •

edited

Loading

stellar-halo left a comment

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 10, 2024

stellar-halo Jan 11, 2024

pump9918 Jan 11, 2024

stellar-halo Jan 11, 2024

pump9918 left a comment

emjayMJkim left a comment

emjayMJkim Jan 11, 2024

emjayMJkim Jan 11, 2024

#19 [ui] 데일리 루틴 뷰 구현 #34

#19 [ui] 데일리 루틴 뷰 구현 #34

Conversation

minemi00 commented Jan 10, 2024 • edited Loading

📑 Work Description

🛠️ Issue

📷 Screenshot

💬 To Reviewers

stellar-halo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pump9918 left a comment

Choose a reason for hiding this comment

emjayMJkim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minemi00 commented Jan 10, 2024 •

edited

Loading