#6 [ui] happy empty view xml #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minemi00
approved these changes
Jan 9, 2024
minemi00
reviewed
Jan 9, 2024
Comment on lines
45
to
48
| app:layout_constraintBottom_toBottomOf="@+id/iv_happy_default_mention" | ||
| app:layout_constraintEnd_toEndOf="@+id/iv_happy_default_mention" | ||
| app:layout_constraintStart_toStartOf="@+id/iv_happy_default_mention" | ||
| app:layout_constraintTop_toTopOf="@+id/iv_happy_default_mention" /> |
There was a problem hiding this comment.
์๋ฐ๊ฑฐ + ์ง์์ ๋ ์ข์๋ฏ?
There was a problem hiding this comment.
๋ฐ์ํ๊ฒ ์ต๋๋ค~
stellar-halo
requested changes
Jan 9, 2024
Comment on lines
2
to
5
| <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> |
There was a problem hiding this comment.
data binding ์ธ ๊ฑฐ๋๊น layout์ผ๋ก ๋ฐ๊ฟ๋ ์ข์ ๊ฒ ๊ฐ์์!
|
|
||
| <ImageView | ||
| android:id="@+id/iv_happy_character" | ||
| android:layout_width="50dp" |
There was a problem hiding this comment.
ํผ๊ทธ๋ง ๋ณด๋๊น ๋๋น๋ 53dp ๊ฐ์๋ฐ ํ์ธํด์ฃผ์ธ์!
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="20dp" | ||
| android:layout_marginTop="43dp" |
There was a problem hiding this comment.
์์ ์ํ๋ฐ์ ํฌ๊ธฐ๋ฅผ ๋นผ์ 43dp๊ฐ ์๋๋ผ 16dp ๊ฐ์์! ํ์ธํด์ฃผ์ธ์!
| app:layout_constraintTop_toTopOf="@+id/iv_happy_default_mention" /> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:id="@+id/rl_happy_empty_card" |
There was a problem hiding this comment.
์๊ฑฐ๋ ์ rl์ผ๊น์?
There was a problem hiding this comment.
์ด์ ์ ๋ฌถ์ ๋ค๋ฅธ ๋ ์ด์์ ์ด๋ฆ์ ๋ชป๋ฐ๊ฟจ๋ค์! ์์ ํ๊ฒ ์ต๋๋ค
stellar-halo
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Work Description
๐ ๏ธ Issue
๐ท Screenshot
๐ฌ To Reviewers