[REFACTOR] 테마 유효성 검증 로직 수정

Team-Sopetit · Jun 28, 2024 · 6a115fc · 6a115fc
1 parent 6fc20ce
commit 6a115fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/com/soptie/server/routine/service/RoutineService.java b/src/main/java/com/soptie/server/routine/service/RoutineService.java
@@ -80,7 +80,7 @@ public Map<Long, List<RoutineVO>> acquireAllInDailyWithThemeId(Set<Long> themeId
 	}
 
 	public Map<String, List<ChallengeVO>> acquireAllInChallengeWithThemeId(long memberId, long themeId) {
-		themeFinder.findById(themeId);
+		themeFinder.isExistById(themeId);
 		val member = memberFinder.findById(memberId);
 		val challengeIdByMember = getChallengeIdByMember(member);
 		val challengeRoutinesByTheme = routineFinder.findChallengeRoutinesByTheme(themeId);

diff --git a/src/main/java/com/soptie/server/theme/adapter/ThemeFinder.java b/src/main/java/com/soptie/server/theme/adapter/ThemeFinder.java
@@ -1,6 +1,6 @@
 package com.soptie.server.theme.adapter;
 
-import static com.soptie.server.theme.message.ThemeErrorCode.*;
+import static com.soptie.server.theme.message.ThemeErrorCode.INVALID_THEME;
 
 import java.util.List;
 
@@ -23,10 +23,14 @@ public List<Theme> findAllOrderByNameAsc() {
 
 	public Theme findById(long id) {
 		return themeRepository.findById(id)
-				.orElseThrow(() -> new ThemeException(INVALID_THEME));
+			.orElseThrow(() -> new ThemeException(INVALID_THEME));
 	}
 
 	public List<Theme> findAllInBasic() {
 		return themeRepository.findAllInBasic();
 	}
+
+	public boolean isExistById(long id) {
+		return themeRepository.existsById(id);
+	}
 }