Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation comments #84

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix deprecation comments #84

merged 1 commit into from
Dec 13, 2024

Conversation

shane-tw
Copy link
Contributor

It needs // or else vscode won't actually warn about the deprecation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12322006395

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.606%
Totals Coverage Status
Change from base Build 11389206348: 0.0%
Covered Lines: 1206
Relevant Lines: 1554
💛 - Coveralls

pawel-banach
pawel-banach approved these changes Dec 13, 2024
View reviewed changes
Copy link

@pawel-banach pawel-banach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shane-tw shane-tw merged commit bed6cad into master Dec 13, 2024
4 checks passed
@shane-tw shane-tw deleted the dep branch December 13, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawel-banach pawel-banach pawel-banach approved these changes

@rafaeljusto rafaeljusto Awaiting requested review from rafaeljusto

@aodhom aodhom Awaiting requested review from aodhom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shane-tw @coveralls @pawel-banach