ci: Use auguwu/clippy-action@1.4.0 to run clippy #17
Clippy (Stable ~ Linux/x86_64)
Clippy failed.
Details
Running cargo clippy took roughly ~1613ms to complete
- Working Directory: repository directory
Annotations
Check failure on line 3288 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3288
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3288:34
|
3288 | s.serialize(self.record, self.key.clone(), self.serializer)
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
= note: `#[deny(clippy::clone_double_ref)]` on by default
help: try dereferencing it
|
3288 | s.serialize(self.record, &(*self.key).clone(), self.serializer)
| ~~~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3288 | s.serialize(self.record, <&str>::clone(self.key), self.serializer)
| ~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 3297 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3297
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3297:47
|
3297 | let _ = self.serializer.emit_unit(self.key.clone());
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
help: try dereferencing it
|
3297 | let _ = self.serializer.emit_unit(&(*self.key).clone());
| ~~~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3297 | let _ = self.serializer.emit_unit(<&str>::clone(self.key));
| ~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 3675 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3675
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3675:34
|
3675 | self.1.serialize(record, self.0.clone(), serializer)
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
help: try dereferencing it
|
3675 | self.1.serialize(record, &(*self.0).clone(), serializer)
| ~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3675 | self.1.serialize(record, <&str>::clone(self.0), serializer)
| ~~~~~~~~~~~~~~~~~~~~~
Check failure on line 3288 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3288
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3288:34
|
3288 | s.serialize(self.record, self.key.clone(), self.serializer)
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
= note: `#[deny(clippy::clone_double_ref)]` on by default
help: try dereferencing it
|
3288 | s.serialize(self.record, &(*self.key).clone(), self.serializer)
| ~~~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3288 | s.serialize(self.record, <&str>::clone(self.key), self.serializer)
| ~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 3297 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3297
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3297:47
|
3297 | let _ = self.serializer.emit_unit(self.key.clone());
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
help: try dereferencing it
|
3297 | let _ = self.serializer.emit_unit(&(*self.key).clone());
| ~~~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3297 | let _ = self.serializer.emit_unit(<&str>::clone(self.key));
| ~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 3675 in /home/runner/work/slog/slog/src/lib.rs
github-actions / Clippy: Rust Stable 1.66.1 (90743e729 2023-01-10)
in
/home/runner/work/slog/slog/src/lib.rs#L3675
using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
Raw output
error: using `clone` on a double-reference; this will copy the reference of type `&str` instead of cloning the inner type
--> src/lib.rs:3675:34
|
3675 | self.1.serialize(record, self.0.clone(), serializer)
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
help: try dereferencing it
|
3675 | self.1.serialize(record, &(*self.0).clone(), serializer)
| ~~~~~~~~~~~~~~~~~~
help: or try being explicit if you are sure, that you want to clone a reference
|
3675 | self.1.serialize(record, <&str>::clone(self.0), serializer)
| ~~~~~~~~~~~~~~~~~~~~~