Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joyce's ActivityBot Chatbot #289

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

JoyceKuode
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOhoo, nice bot you've created! I was unreasonably happy when the whole thing turned yellow 😂 Let's go through some feedback!

JavaScript

  • I really like what you did here with the different conditions and options for the user ⭐ Makes it feel very thought-through and fun.
  • Nice execution of the flow ⭐

Clean Code

  • Be consistent with whether you're using double or single quotes. However, HTML attributes should always be double quotes
  • Descriptive variable names! But don't be afraid to have a bit longer names, e.g. askForFavouriteColor instead of getColor.

Good job Joyce, keep it up!

Comment on lines +256 to +259
// Change color scheme
const changeColorScheme = (scheme) => {
document.body.className = scheme
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ 😍

Copy link

@jacquelinekellyhunt jacquelinekellyhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love your chatbot! The use of the color gradients and overall design choices are visually pleasing - great selections! Everything is so well-organised, and the bottom-to-top structure is fantastic. It genuinely makes reading easier compared to the usual top-down approach. At this point in the bootcamp, I don’t have any critical feedback. Each review feels like a valuable learning opportunity! So keep up the amazing work! 🤩

<button id="purple">🟣 Purple</button>
<button id="green">🟢 Green</button>
<button id="pink">🩷 Pink</button>
`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was sooo cool to see when you demod! so creative - love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants