Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1 with some pictures and text and buttons #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NirakRe
Copy link

@NirakRe NirakRe commented Oct 1, 2021

I want to make a website about my bikes.
I could link multiple pages. I had difficulty centering images.
I wanted to round up the photos for "about me", but that didn't work out yet. Next I want to change the position of the photos in "About me". In a further step I would like to make an input window for tours. Much work to do...

Copy link

@esteficodes esteficodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈Looks very good so far! I know it's a work in progress, but it's a great start. Try to add some media queries so that your site looks beautiful in every kind of device. See how the images behave then. Your pictures go over their container when I try mobile display. Starting with mobile-first design is the best way to go about this. 😀

<a href="https://ride.ch">Für Bikeinteressierte</a>
</div>

<menu>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Nice to meet you! 👋 I'm Estefanía and I'll be taking a look at your code today so that we can leave it functional and shiny.🙂

Comment on lines +27 to +33
<menu>
<a href="./index.html">Home</a>
<a href="./bike.html">Bike</a>
<a href="./rennvelo.html">Rennvelo</a>
<a href="./ebike.html">E-Bike</a>
<a href="./ueber_mich.html">Über mich</a>
</menu>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out the indentation here! menu's closing tag should be in line with the opening tag. 😀

Comment on lines +32 to +38
<menu>
<a href="./index.html">Home</a>
<a href="./bike.html">Bike</a>
<a href="./rennvelo.html">Rennvelo</a>
<a href="./ebike.html">E-Bike</a>
<a href="./ueber_mich.html">Über mich</a>
</menu>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before with the indentation. 😀

Comment on lines +9 to +10
.rund{border-radius: 50%;}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your comment you mention that you want to round up your images, but I can't find the element/s that you applied this class to. Are you sure you are calling it by the right class so that border-radius is applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants