Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personal website V1 #42

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

personal website V1 #42

wants to merge 32 commits into from

Conversation

NikkiJoy
Copy link

@NikkiJoy NikkiJoy commented Oct 2, 2021

The first version of my website.

In the end I will probably only have one site, instead of 3. In a next step, I want to change the bullet points to cards with images. And I want a form to reach out to me.

Here's the published site: https://nikkiboehler.netlify.app/

Thx

Copy link

@esteficodes esteficodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨Nice job so far! You even published your site to Netlify and I can see that all the links work fine. The next step would be to add some media queries so that your site displays beautifully in every device screen, because it look a little bit weird when it tries to take a whole desktop big screen. Remember to start designing from the mobile display.
Well done so far! it's a neat and clean code with a correct indentation. Now let's go for more!🌈

<!DOCTYPE html>
<html>

<head>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I'm Estefanía and i'll be taking a look at your site today so that we can leave it as functional and shiny as possible.👋😊

code/index.html Outdated Show resolved Hide resolved
Comment on lines +27 to +58
<div>
</div>

<!-- Current Roles-->
<div class="boxes">
<h2>Current Roles</h2>
<ul>
<li>Opendata.ch, Director</li>
<li>Arui, Co-Director</li>
<li>SGG, Board Member</li>
</ul>
</div>

<!-- Ventures I co-founded-->
<div class="boxes">
<h2>Ventures I Co-Founded</h2>
<ul>
<li>Prototype Fund (Incubation Program)</li>
<li>Digitales Lernlabor (NGO)</li>
<li>Data Café (Awareness Campaign)</li>
</ul>
</div>

<!-- Public-->
<div class="boxes">
<h2>Media, Publications & Talks</h2>
<ul>
<li>«Die Förderung von Datenkompetenz ist auch Aufgabe der Medien» – Article on data literacy in SRG Link Magazine</li>
<li>My recommendations at the onset of the pandemic – Opinion statement in Strategiedialog 21</li>
<li>Warum ein Schweizer Verein für mehr Klimadaten kämpft – Interview about climate data in Yova’s Blog </li>
</ul>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the section tag for all of this boxes instead of divs to make them more semantic?

code/style.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants