Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

designed my first website project. #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GianninaBinder
Copy link

I made myself a layout to a portfolio page.

Copy link

@esteficodes esteficodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈Impressive portfolio site! 🦄 It's really a great choice of colors and a beautiful layout. The art on the site is the star, just as it should be, well done!
The code is very neat and you did great using flexbox. The links are working ok. Don't forget to erase any comments that are not necessary once you are done. Also: the next step would be to add some media queries so that your site can be enjoyed in every device screen. Remember to start designing from the mobile screen display as it's everybody's first choice nowadays. You can read more about media queries and responsiveness here. Amazing work so far. Way to go!

@@ -0,0 +1,30 @@
<html>

<head>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Nice to meet you! My name is Estefanía and I'll be taking a look at your code today. 👋😃

Comment on lines +13 to +23
<header>
<h2> Home</h2>
<h2> About</h2>
<h2> Work</h2>
<h2> Contact</h2>
</header>

<div>
<h1> About me</h1>
<p> I am bla bla bla</p>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice indentation!

Comment on lines +24 to +30
<div class="textabschnitt">
<p> I studied Animation at the University of Art and Design in Lucerne with the main focus on CGI Animation, Concept Art and Storyboarding.
At the Moment i'm doing an internship at an advertisment studio in Zurich.
My passion lies in drawing and painting, as well as animating.
At the moment i'm learning how to do Frontend design.
</p>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with indentation at all times. The rule to follow here is that if there's a new block, then you indent one more level. At Technigo, we use 2 spaces for indentation. 🔍

Comment on lines +26 to +27
<p> giannina@haldenweg.ch
</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is your friend. Don't forget about her.🙂

Comment on lines +59 to +62
menu a:hover {
background:rgb(78, 144, 137);
color: white;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice with a hover effect!

Comment on lines +99 to +102
flex-direction: row;
justify-content: center;
margin-right: 50%;
align-items: baseline;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat usage of flexbox!✨✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants