Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kathalin's Project #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Project Name
# Project Name Jessy Vagabunda

Replace this readme with your own information about your project.

Expand Down
Binary file added code/Images/IMG_3058.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/Images/IMG_3059.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/Images/IMG_3060.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
55 changes: 39 additions & 16 deletions code/index.html
Original file line number Diff line number Diff line change
@@ -1,21 +1,44 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Nice to meet you! I'm Estefanía and I'll be taking a look at your code today. 👋😀

<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>somewhere between paper an skin</title>
<link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>

<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Project Name</title>
<!-- dont forget to add a css file and link it here! -->
<!-- If you're using google fonts, that should be added here -->
</head>
<body>
<!--
Write your code here inside the body to make it appear in the browser.
Below is an example on how to use an image tag. Copy it and add it in the body, but outside the comment tag if you want to see how it looks like on the website. Then you can change the size and other styling for it in the css file.
<nav>
<div class="nav"></div>
<ul>
<li><a href="#">/art work</a></li>
<li><a href="#">/tattoo art</a></li>
<li><a href="#">/about</a></li>
<li><a href="https://instagram.com/jessy.vagabunda?utm_medium=copy_link">/insta</a></li>
</ul>
Comment on lines +14 to +19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with indentation here. 🔍 The rule to follow is that if there's a new block, then you indent one more level. At Technigo, we use 2 spaces for indentation. The list's closing tag should be in line with its opening tag. 🙂

</nav>

<img src="example-recipe-background.png" alt="Banana Bread">
<div class="wrapper">
<div><img src="./Images/IMG_3058.jpg" alt="hund"></div>
<div><img src="./Images/IMG_3059.jpg" alt="hund"></div>
<div><img src="./Images/IMG_3060.jpg" alt="hund"></div>
</div>
<div>
<div class="grey-box">
<h2>somewhere between paper an skin</h2>
<style>
img {
max: fullscreen;
height: auto;
}
</style>
</div>
Comment on lines +28 to +36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmhh, looks like the styling for this image is broken or something is missing because the editor doesn't acknowledge the property "fullscreen". Also: maybe it would be a good idea to place all of your styling in the css file? 🙂


-->
<h1>Hello there! 👋🏼</h1>
</body>
<div class="wrapper2">
<div><img src="./Images/IMG_3058.jpg" alt="hund"></div>
<div><img src="./Images/IMG_3059.jpg" alt="hund"></div>
<div><img src="./Images/IMG_3060.jpg" alt="hund"></div>
</div>
</body>
</html>
48 changes: 45 additions & 3 deletions code/style.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,47 @@
/* Here in the css file you'll write your styling. make sure to link the css file to the html file. If it's linked correctly you should see a light blue background. */
body { font-family: "Gill Sans Extrabold", Helvetica, sans-serif }

body {
background-color: lightblue;
.receipt { font-family: Courier, "Lucida Console", monospace }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code will look neater if you write it like this:

.receipt {
font-family: Courier, "Lucida Console", monospace;
}

And don't forget the semicolons at the end of css statements. ✔️


nav ul {
list-style-type: none;
display: grid;
grid-template-columns: repeat(4, 1fr);
grid-auto-rows: auto;
Comment on lines +6 to +9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done using grid!

}

nav ul li a:hover, nav ul li a:focus {
color: black;
background-color: white;
font-weight: bold;
}
Comment on lines +12 to +16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool hover effect on that nav menu.


nav ul li a {
padding: 0.25em 1em;
color: black;
text-decoration: none; /* no underline */
font-size: 40px;
background-color: white
}

.wrapper {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-auto-rows: auto;
}

.grey-box {
background-color: grey;
padding: 20px;
margin-top: 40px;
margin-bottom: 40px;
width: 100%;
font-size: xx-large;
text-align: center;
}

.wrapper2 {
display: grid;
grid-template-columns: repeat(3, 1fr);
grid-auto-rows: auto;
}