Julia's project 1 #47
Conversation
There was a problem hiding this comment.
🌈Good job so far! I like the way your site looks in a desktop display. However, making it responsive will make things more interesting. You can add some media queries and start designing from mobile screen display. Well done with the indentation, your code looks nice and clean. Keep working with the box model so that you can correctly put spaces among your elements. Well done so far! ✨✨
| @@ -0,0 +1,117 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="de"> | |||
| <head> | |||
There was a problem hiding this comment.
😀Hi! Nice to meet you! I'm Estefanía ad I'll be taking a look at your code so we can leave it as functional and shiny as possible.✨
There was a problem hiding this comment.
Hi Estefanía nice to meet you! Thank you for the feedback ✨
|
|
||
| <header> | ||
| <h1>Anna Leutert</h1> | ||
| <h2>Handweberin, Textil- und Farbdesignerin</h2> | ||
| </header> | ||
| <nav id="navigation"> | ||
| <ul> | ||
| <li><a href="index.html">Home</a></li> | ||
| <li><a class="active" href="about.html">Über Mich</a></li> | ||
| <li><a href="kontakt.html">Kontakt</a></li> | ||
| <li><a href="portfolio.html">Portfolio</a></li> | ||
| </ul> | ||
| </nav> |
| <div class="flex-container2"> | ||
| <h3>Mit viel Begeisterung weben.</h3> | ||
| <p>Mein ganzes Leben schon bin ich fasziniert von bunten Fäden, und was daraus gemacht werden kann. Ich fühle mich wohl beim Weben, das ist meine Welt. Ich Stricke auch sehr viel. Mit bunten Fäden, alles mit bunten Fäden. Und da kommt schon das nächste..... bunt. Farbe! Farbe und wie sie wirkt, und warum sie so wirkt, und welches ist an dieser Stelle die Beste aller Farben. Das beschäftigt mich. Das Intressiert mich. Das ist meine Welt. Das ist mein Beruf. | ||
| <br> |
There was a problem hiding this comment.
This little friend, the br tag, is not used anymore nowadays. Now we totally rely on the box model to take care of the layout in our sites. 😀 So here you can remove it and just adjust margins, paddings and everything that is needed to give your boxes the room that you want to give to them. You can test that by inspecting with your dev tools in the console: add some padding and margin and see what looks best. 🔍
There was a problem hiding this comment.
oh thank you, I will try this 😊
| nav a:hover, a:active{ | ||
| color: black; | ||
| } | ||
| nav .active{ | ||
| color: black; | ||
| } |
| <table> | ||
| <tr> | ||
| <th>1981 - 1984</th> | ||
| <td>Ausbildung, Handweberin EFZ, BFF Bern</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1984</th> | ||
| <td>Praktikum, Leinenweberei Bern</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1984 - 1986</th> | ||
| <td>Studium, Textildesign FA, Schweizerische Textilfachschule, Wattwil</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1986 - 1988</th> | ||
| <td>Arbeit, Habis Textil AG, Flawil</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1990 - 1997</th> | ||
| <td>Leitung Webatelier, Landwirtschafts- und Bäuerinnenschule, Willisau</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1991</th> | ||
| <td>2. Platz Intern. Design-Preis, Österreich</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1999 - 2020</th> | ||
| <td>Kursleiterin, Zürcher Stalder AG, Kirchberg</td> | ||
| </tr> | ||
| <tr> | ||
| <th>1999 - 2020</th> | ||
| <td>Kursleiterin, Spycher Handwerk Grädel, Huttwil</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2001 - 2007</th> | ||
| <td>Weben in der Beschäftigung, Alters- und Pflegeheim, Lohn-Ammansegg</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2006 - 2020</th> | ||
| <td>Weben und Produktdesign, Stiftung Sonnenbühl, Konolfingen</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2008 - 2013</th> | ||
| <td>Ausbildung, Ausbilderin FA, Migros Klubschule, Bern</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2008 - 2020</th> | ||
| <td>Kursleiterin, Genossenschaft Migros Aare, Wankdorf</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2009 - 2020</th> | ||
| <td>Leitung Webatelier, INFORAMA, Hondrich</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2009 - 2014</th> | ||
| <td>Präsidentin, Verein IG Weben, Berufsverband der WeberInnen in der Schweiz</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2015 - </th> | ||
| <td>Prüfungsexpertin der Gewebegestalterinnen</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2013 - 2020</th> | ||
| <td>Weben und Produktdesign, Huus Regenbogen, Wattenwil</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2013 - 2015</th> | ||
| <td>Studiengang, Farbdesign FA, Schweizerische Textilfachschule, Wattwil</td> | ||
| </tr> | ||
| <tr> | ||
| <th>2020 - </th> | ||
| <td> Olvido, Spiez</td> | ||
| </tr> | ||
| </table> |
There was a problem hiding this comment.
I'm not 100% sure about this table usage here. I found this about the topic.
There was a problem hiding this comment.
Ok I see, a table is not such a great solution. 😅 What would you recommend? Do I have to make one div element and two items for each line? 🤔
I've created a website for/about my mother, she is a textil and color designer. I already made a website for here with squarespace, but I was not happy with it.
The portfolio page is still in progress, so the buttons will not work.