Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel blog #49

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions README.md

This file was deleted.

Binary file removed code/example-recipe-background.png
Binary file not shown.
Binary file added code/images/AlvaneuSkateline.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/Davos Bolgen.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/DavosBolgen.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/DavosEisstadion.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/Engadin.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added code/images/family.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 0 additions & 21 deletions code/index.html

This file was deleted.

196 changes: 196 additions & 0 deletions code/ontour_20211120.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,196 @@
@import url(https://fonts.googleapis.com/css?family=Reenie+Beanie);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! My name is Karin and I will take a review your code today 😊

Nice with a custom font! 😊👍


body{
background:rgb(238, 232, 170)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using rgb-values are perfectly fine, but it's more common to use hex-values, for example #ffffff = white. There is also an option to use rgba(xx, xx, xx, AA), where AA stands for alpha (opacity). And don't forget about the semi-colons at the end! 😊😊

}

h1 {
color: rgb(96, 96, 84);
font-family: "Reenie Beanie";
font-size: 50px;
margin: 40px 40px 40px 80px;
}

h2 {
color: rgb(96, 96, 84);
font-family: "Reenie Beanie";
font-size: 50px;
margin: 40px 40px 40px 0px;
}

h3 {
color: rgb(96, 96, 84);
font-family: "Reenie Beanie";
font-size: 50px;
margin: 40px 40px 40px 0px;
}

article {
min-height: 600px;
background-color: rgb(238, 232, 170);
color: rgb(96, 96, 84);
padding: 5em;
}


.paragraph {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to target the p-tag only, the paragraph, you don't need to use a class name for it. :) All you need is p, without a dot or anything else, like so:

p {
....
}

color: rgb(96, 96, 84);
font-family: "Reenie Beenie";
font-size: 30px;
font-weight: 200;
}

menu{
display: flex;
align-items: center;
justify-content: space-between;
font-family: "Reenie Beanie";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want "Reenie Beanie" applied to the entire page, you could put it on the body-tag, and specify if you want a different font wherever you want it. 😊

Like this:

body {
    font-family: "Reenie Beanie";
}

.some-other-class {
    font-family: "Some other font";
}

border: 5px;
border-color: rgb(96, 96, 84)(96, 96, 84);

}

menu a {
display: flex;
padding: 10px 15px;
background: hsla(44, 75%, 50%, .1);
color: rgb(96, 96, 84);
font-size: 40px;
font-weight: bold;
text-decoration:none;
border-radius: 10px;
margin: 10px;

}

menu a:hover {
background: rgb(238, 221, 130);
color: white;
}

#galerie {
box-sizing: border-box;
background-size: 58px 58px;
background-position: 0px 2px, 4px 35px, 29px 31px, 34px 6px;
Comment on lines +71 to +74

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what these three rows are doing, but I think another way going about this would be to use flexbox, and having the box model in mind. 😄 I would also recommend using a class instead of an id for this. 👍🏻 For example, you could put the following on this tag:

.galerie {
    // will set the wrapper-box to full width
    width: 100%;

     // These three rows sets the display to flex, and place all content in the center
    display: flex;
    align-items: center; 
    justify-content: center; 

    // When you've assigned a width to all divs in this wrapper, you'll have to use flex to make 
    // the fourth box move down to the second row.
    flex-wrap: wrap; 
}

....

padding: 0 50px;

}


#galerie div {
background: #FFF;
box-shadow: 0 0 4px rgba(0, 0, 0, 0.2);
display: inline-block;
height: 240px;
overflow: hidden;
margin: 40px 0px 0 20px;
padding: 5px 5px 40px 5px;
width: 240px;
transition: all 0.25s ease-in;
}
Comment on lines +80 to +90

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... and in here we would then set the width of the div to be 33.3% - if you want to have 3 in a row. In that way you'll be able to scale the content, and by doing so you don't have to do as much work to make the site responsive. 😊 I do love the hover-effects and the transition! Great job with that. 🌟🌟🌟

The code could look something like this:

.galerie div {
	width: 33.3%;
	height: 240px;
	background: #FFF;
	box-shadow: 0 0 4px rgba(0, 0, 0, 0.2);
	margin: 40px 0px 0 20px;
	padding: 5px 5px 40px 5px;
	transition: all 0.25s ease-in;
}


#galerie div img {
width: 240px;
height: 240px;
}
Comment on lines +92 to +95

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you could change width to 100%, and height to 100%. 😊


#galerie div:hover,
#galerie div:focus {
box-shadow: 0 15px 35px rgba(0, 0, 0, 0.8);
width: 240px;
z-index: 2;
transform: scale(2);
}

#galerie figcaption {
color: rgb(96, 96, 84);
font: cursive 10px/150%;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the font cursive and changing size/line height, you'll have to write like this:

font-style: italic;
font-size: 10px;
line-height: 150%;

font-family: "Reenie Beanie", cursive;
text-align: left;
width: 240px;
font-size: 20px;

}

#galerie figure:nth-child(3n-2):hover,
#galerie figure:nth-child(3n-2):focus {
transform: scale(2) rotate(-2.5deg);
}

#galerie figure:nth-child(5n):hover,
#galerie figure:nth-child(5n):focus {
transform: scale(2) rotate(2.5deg);
}

#galerie:after {
clear: both;
content: " ";
display: block;
}

.parallaxhead {
background-image: url("images/family_web1.jpg");
min-height: 60vh;
width: 100%;
background-position: center;
background-repeat: no-repeat;
background-size: cover;
background-attachment: fixed;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Looks super nice! 🌟

}

.parallaxwir {
background-image: url("images/DavosEisstadion.jpg");
min-height: 60vh;
background-position: center;
background-repeat: no-repeat;
background-size: cover;
background-attachment: fixed;
}

.parallaxplan {
background-image: url("images/LaaxSkipiste.jpg");
min-height: 60vh;
background-position: center;
background-repeat: no-repeat;
background-size: cover;
background-attachment: fixed;
}
Comment on lines +141 to +157

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you could separate the background-image source from the other settings into two classes, to avoid having to repeat the same settings every time. 😊

For example:
<div class="parallaxwir"></div>
could instead be:
<div class="parallax wir"></div>

and the styling would look like this:

.parallax {
        min-height: 60vh;
	background-position: center;
	background-repeat: no-repeat;
	background-size: cover;
        background-attachment: fixed;
}

.wir {
	background-image: url("images/LaaxSkipiste.jpg");
}

By doing like this, you would only have to add more source-classes if you want the image to be different. 👌

For example:
<div class="parallax plan"></div>
+

.plan {
	background-image: url("images/other-image.jpg");
}


.parallaxhighlight {
background-image: url("images/LaaxSkipiste.jpg");
min-height: 60vh;
background-position: center;
background-repeat: no-repeat;
background-size: cover;
background-attachment: fixed;
}

.parallaxgalerie {
background-image: url("images/LaaxSkipiste.jpg");
min-height: 60vh;
background-position: center;
background-repeat: no-repeat;
background-size: cover;
background-attachment: fixed;
}

@media only screen and (max-width: 667px) {
#galerie {
width: 100%;
margin: 100px auto;
}
}

@media only screen and (max-width: 1024px) {
body {
width: 100%;
margin: 2% 0;
padding: 5%;
}
#galerie {
width: 850px;
margin: 100px auto;
}
}


117 changes: 117 additions & 0 deletions code/ontour_20211120.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
<!DOCTYPE html>
<html lang="de">

<head>
<meta charset="UTF-8"/>
<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
<meta name="viewport" content="width=device-width, initial-scale=1.0"/>
<title>Fünf auf Tour</title>
<link rel="stylesheet" type="text/css" href="ontour_20211120.css"/>
</head>

<body>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good usage of semantic HTML-tags! 🌟

<h1>Wir legen los, unsere Reise beginnt!</h1>

<div class="parallaxhead"></div>

<menu>
<a href="#wir">Wir Fünf</a>
<a href="#plan">Unser Plan</a>
<a href="#highlight">Unsere Highlights</a>
<a href="#galerie">Fotos</a>
<a href="#besteplaetze">Beste Übernachtungsplätze</a>

</menu>

<main>
<article>
<h2 id="wir">Wir fünf auf Tour</h2>
<p class="paragraph">Ein bisschen verrückt, ein bisschen chaotisch und ein bisschen bünzli.
Comment on lines +26 to +29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try to add some indentation to your code, to make it easier to read. 😊

Wir sind Linda, Nando, Milena, Daniela und Fabian.
Reisen ist seit jeher unsere Leidenschaft. Fabian war bereits als Kind mit seinen Eltern viel auf reisen und hat sogar ein Jahr in Kanada verbracht.
Daniela hat ihre Liebe zum Reisen bei verschiedenen Trips durch Lateinamerika neu entdeckt.
Zusammen haben wir verschiedene Teile der Welt erkundet. Mit Backpack, Bus, Wohnmobil und Auto.
Nun wollen wir unseren Kindern zeigen, dass es sich lohnt, in die Welt heraus zu gehen und Neues zu entdecken.
Ausserdem wollen wir die Zeit als Familie geniessen und uns fern von Alltag und Verpflichtungen einfach treiben lassen.
</p>
</article>

<div class="parallaxwir"></div>

<article>
<h2 id="plan">Unser Plan - keinen zu haben</h2>
<p class="paragraph">Da wir echte Winterkinder sind, nehmen wir uns zuerst einfach mal Zeit, den Schnee so richtig zu geniessen.
Wir verbringen deshalb die ersten fünf Wochen unseres Abenteuers in den Schweizer Alpen mit skifahren, schlitteln, Schneemann bauen und schlittschüelen.
Den Rest der Reise haben wir nicht geplant. Wir packen einfach das Wohnmobil und schauen, wo uns die Reise hinführt. Einzig die Erkundung von Schweden ist unser Ziel.
Wann, wie lange und wo genau - da lassen wir uns treiben. Wir sind gespannt, wo uns die Reise hinführt.
</p>
</article>

<div class="parallaxplan"></div>

<!--Bild(er) und kurzen Text einfügen-->
<article>
<h2 id="highlight">Unsere Highlights</h2>
<p class="paragraph">Unsere lustigsten, eindrücklichsten oder bewegendsten Erlebnisse auf unserer Reise möchten wir euch nicht vorenthalten. Hier erzählen wir euch, was
uns in unserem Reisealltag beschäftigt.
</p>
</article>

<div class="parallaxhighlight"></div>

<!--Bildgalerie ergänzen-->
<article>
<h2 id="galerie">Fotos der schönsten Orte</h2>
<p class="paragraph">Wir besuchen so viele tolle Orte und sind beeindruckt von der Natur, den Menschen und den aussergewöhnlichen Dinge, die wir sehen dürfen.
Hier findet ihr unsere tollsten Fotos.
</p>

<h3>Davos</h3>
<section id="galerie">
<div> <img src="images/DavosBolgen.jpg" alt="Schneespass auf dem Bolgen">
<figcaption>Skischule auf dem Bolgen</figcaption>
</div>
<div> <img src="https://wiki.selfhtml.org/images/4/4a/Lauf-2.jpg" alt="Lauf an der Pegnitz - Pegnitz">
<figcaption>Brücke über die Pegnitz</figcaption>
</div>
<div> <img src="https://wiki.selfhtml.org/images/2/24/Lauf-3.jpg" alt="Lauf an der Pegnitz - Nürnberger Tor">
<figcaption>Mauermühle und Judenturm</figcaption>
</div>
<div> <img src="https://wiki.selfhtml.org/images/e/e7/Lauf-4.jpg" alt="Lauf an der Pegnitz - Rathaus">
<figcaption>Rathaus</figcaption>
</div>
</section>

<h3>Italien</h3>
<section id="galerie">
<div> <img src="images/Davos Bolgen.jpg" alt="Lauf an der Pegnitz - Wappensaal">
<figcaption>Wappensaal im Wenzelschloss</figcaption>
</div>
<div> <img src="https://wiki.selfhtml.org/images/c/c2/Lauf-6.jpg" alt="Lauf an der Pegnitz - Schleifmühle">
<figcaption>Reichel'sche Schleifmühle</figcaption>
</div>
<div> <img src="images/DavosBolgen.jpg" alt="Schneespass auf dem Bolgen">
<figcaption>Skischule auf dem Bolgen</figcaption>
</div>
</section>

</article>

<div class="parallaxgalerie"></div>

<article>
<h2 id=besteplaetze>Beste Übernachtungsplätze</h2>
<p class="paragraph">Wir lieben campen. Was uns aber nicht so gefällt, sind überfüllte Campingplätze, bei denen man sich wie im Hasenstall vorkommt.
Wir haben gerne ein bisschen mehr Platz und brauchen kein Glamping.
Geht es dir auch so? Hier haben wir eine Liste mit unseren Lieblingscamping- und Stellplätzen zusammengestellt.
</p>
</article>


<footer>
<p> © 2021 by Daniela </p>
</footer>


</body>

5 changes: 0 additions & 5 deletions code/style.css

This file was deleted.

Loading