Big change always starts with small ideas! Project 3 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Readme! Italic
I added a Hamburger menu, however I failed to made it work (I need some java script). I finished with the desktop mobile adjustments I added a footer
I added a Feedback Form in the About me page.
Added footer icons (not linked yet), they only appear on the start site and not on the other sites (I don't know why). On the about me site: added a Feedback Box: Button, Text box, Mail box
I changed some styling on the feedback website. Used a texture instead of an input which allowed me to increase the text box size. I made each field responsive.
Projet 3: Spark conversations Forum, style, and data sent between webpages and services. - Buttons (Link) - Submit Button - Text Fields
|
Hi Rebecca! I have done a code review on this project already - haven't I? I just can't find it 🤔 I'll make a short new one anyway and you can ping me if you have any questions. |
HIPPIEKICK
reviewed
Dec 5, 2022
Comment on lines
+7
to
+11
| <title>BIG CHANGE ALWAYS STARTS WITH SMALL IDEAS!</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"/> | ||
| <link rel="icon" type="image/x-icon" href="/Users/rebeccabrogli/Desktop/Project1/project-p1-first-webpage-master/images/bulb_on.svg"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"> | ||
|
|
There was a problem hiding this comment.
Would be so nice with a favicon here as well 😊
| <div> </div> | ||
| </div> | ||
|
|
||
| <img src="/Users/rebeccabrogli/Desktop/Desktop - Rebecca’s MacBook Air/Project1/project-p1-first-webpage-master/images/bulb_on.svg" alt="Big Idea Logo"> |
There was a problem hiding this comment.
You need to add any images to your uploads, this will only show on your computer since it's a local path.
Comment on lines
+36
to
+37
| <section class="welcome-comtainer"> | ||
| <div class="titel"> |
There was a problem hiding this comment.
Spelling of class names will help you when you reuse them ;)
| </div> | ||
| </section> | ||
|
|
||
| <section class="idea-boxes"> |
Comment on lines
+91
to
+101
| <footer> | ||
| <div class="footer-content"> | ||
| <h4>More about me!</h4> | ||
| <ul class="socials"> | ||
| <li><a href="#"><i class="fa fa-linkedin-square"></i></a></li> | ||
| <li><a href="#"><i class="fa fa-linkedin"></i></a></li> | ||
| <li><a href="#"><i class="fa fa-envelope"></i></a></li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| </footer> |
| <h4> How did you like the journey through the website?</h4> | ||
| <h4> Please leave a Feedback 👍🏽</h4> | ||
|
|
||
| <form action="https://httpbin.org/anything" method="post"> |
There was a problem hiding this comment.
Aha - I guess this is the new part!
Comment on lines
+352
to
+357
| form { | ||
| max-width: 500px; | ||
| text-align:center; | ||
| border-radius: 5%; | ||
| margin: 0 auto; | ||
| } |
| max-width: 100%; | ||
| } | ||
|
|
||
| textarea { |
There was a problem hiding this comment.
I usually prevent resize of the textarea to not give the user the ability to break the design:
resize: none;
Comment on lines
+417
to
+436
| input:valid { | ||
| background-color: rgb(244, 136, 97, 0.7); | ||
| font-weight: bold; | ||
| color: rgb(255, 233, 214); | ||
| } | ||
|
|
||
| input:invalid { | ||
| background-color:rgba(244, 136, 97, 0.488); | ||
| color: rgb(255, 233, 214); | ||
| } | ||
|
|
||
| textarea:valid { | ||
| background-color: rgb(244, 136, 97, 0.7); | ||
| font-weight: bold; | ||
| color: rgb(255, 233, 214); | ||
| } | ||
|
|
||
| textarea:invalid { | ||
| background-color:rgba(244, 136, 97, 0.488); | ||
| } |
There was a problem hiding this comment.
Nice with these different styles! Makes it more comprehensible
Comment on lines
+463
to
+466
| .SubmitButton:hover { | ||
| background-color: rgb(244, 136, 97); | ||
| font-weight: bold; | ||
| } |
There was a problem hiding this comment.
Very nice that the styling is aligned with the rest of the page 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finished now with the third project and I had some issues making pull requests. I hope this time it worked.
Thanks a lot for your comments.