Elianes Project_final version #61
Conversation
Didn't send videos, because of space, but they are running. ;-)
restartet from scratch on a mobile first basis and made the website responsive
|
started over on a mobile first basis and made the site responsive. |
new background image, added real text, added fun facts, fixed backdrop-filter for iOs
There was a problem hiding this comment.
Really good job Eliane! I learned something new while reviewing your code, so thanks for that. Good choice to go mobile-first, and overall a good result and nice looking code. I would advise you to clean up the folder structure of your repo as you seem to have some duplicates, and also some images are in folders and some others are not. Also - it's good practice to always name your files in kebab-case (lowercase and dashes between words)
| <div id="hamburger-items"> | ||
| <a href="#top">Home</a> | ||
| <a href="#Aboutme">About me</a> | ||
| <a href="#Career">Career</a> | ||
| <a href="#CV">CV</a> | ||
| <a href="#Languages">Skills</a> | ||
| <a href="#Contact">Contact</a> | ||
| </div> |
|
|
||
| <h2> | ||
| Marketing Manager | ||
| <br /> |
There was a problem hiding this comment.
The br tag is actually deprecated! We can achieve the same result using just paragraph tags (because they are set to display: block; as default)
| <img | ||
| class="img-rund" | ||
| src="Bilder/Portrait_grey.jpg" | ||
| alt="Portait" |
There was a problem hiding this comment.
Great that you're using alt tags!
| onmouseover="src='Bilder/Dive portrait grey.jpg'" | ||
| onmouseout="src='Bilder/Portrait_grey.jpg'" |
There was a problem hiding this comment.
Love this, didn't know it existed!
| margin: 0; | ||
| } | ||
|
|
||
| /*Schriften*/ |
There was a problem hiding this comment.
Great that you have divided your CSS into these different sections! To make it even more "clean", you could order your headlines in h1-h5 order as well :)
| .flex-intro { | ||
| align-items: center; | ||
| justify-content: center; | ||
| margin: 0px; | ||
| background-color: black; | ||
| flex-direction: column; | ||
| display: flex; | ||
| } |
There was a problem hiding this comment.
Is flexbox really needed here?
And PS. It's good practice to add the display: flex; property before the other flex properties
There was a problem hiding this comment.
Also, I see you've used flexbox on a lot of different elements. How about creating another class with all those properties. Since HTML elements can have more than one class name, that might make your CSS file shorter and more following DRY principle ("Don't repeat yourself").
Didn't send videos, because of space, but they are running. ;-)