Hand in Project 1 #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
reviewed
Nov 21, 2023
Comment on lines
+8
to
+18
| <div class="navigationLink"> | ||
| <div class="navElement"> | ||
| <a id="nav1" class="navigationLink" href="./index.html">Home</a> | ||
| </div> | ||
| <div class="navElement"> | ||
| <a id="nav2" class="navigationLink" href="./projects.html">Projekte</a> | ||
| </div> | ||
| <div class="navElement"> | ||
| <a id="nav3" class="navigationLink" href="./contactme.html">Contact</a> | ||
| </div> |
There was a problem hiding this comment.
These elements doesn't belong in the head. All content except meta content should be in the body :)
Comment on lines
+32
to
+35
| <div>Digital Product Management Assistant</div> | ||
| <div>Studentin BSc Informatik - iCompetence</div> | ||
| </h2> |
There was a problem hiding this comment.
Instead of having divs inside the h2, you could achieve the same result by having two h2s
|
|
||
| <div class="pictureofmyself"> | ||
| <img class="me" src="./img/IMG_8272.jpg" alt="A picture of Tamira"/> |
|
|
||
| </div> | ||
| <a href="#top" class="top">Back to top🔼</a> |
| @@ -1,5 +1,279 @@ | |||
| /* Here in the css file you'll write your styling. make sure to link the css file to the html file. If it's linked correctly you should see a light blue background. */ | |||
| @media (max-width: 668px) { | |||
There was a problem hiding this comment.
We usually start with the default styling and then put the media queries further down.
| background-image: url("./img/ReUse.jpg"); | ||
| background-size: cover; | ||
| } | ||
| #I\ follow\ you{ |
There was a problem hiding this comment.
Is this an id? It looks broken
| } | ||
|
|
||
|
|
||
| .berufsEintrag { |
There was a problem hiding this comment.
Class names and ids should actually all be in English
| padding: 10px; | ||
| margin: 20px; | ||
| border-radius: 20px; | ||
| box-shadow: 0 0 10px rgba(5, 48, 140, 0.3); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.